Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- Class \Drupal\image\Entity\ImageStyle has a method getPathToken() which is not in interface \Drupal\image\ImageStyleInterface. However, method deliver() of class \Drupal\image\Controller\ImageStyleDownloadController calls this method on parameter $image_style which is typed as \Drupal\image\ImageStyleInterface.
- File ImageStyleInterface.php also still mentions "@see \Drupal\image\ImageStyleInterface::deliver()"
- File ImageStyleInterface.php has a "use Drupal\image\ImageEffectInterface;" statement while that class is in the same namespace and thus does not have to be declared with a use statement.
- ImageStyleInterface uses the deprecated drupal_get_private_key().
Proposed resolution
Add method to interface and resolve the other 3 issues.
Remaining tasks
Write patch.
User interface changes
None.
API changes
Method is added to API but will be documented automatically.
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 1.52 KB | fietserwin |
#3 | 2198325-3.patch | 2.67 KB | fietserwin |
#1 | 2198325-1.patch | 2.37 KB | fietserwin |
Comments
Comment #1
fietserwinComment #2
mondrakeMinor things
{@inheritdoc} enclosed in curly brackets
ImageStyleDownloadController (with capital 'C' for Controller)
Comment #3
fietserwinChanged + removed a deprecated use of drupal_get_private_key().
Comment #4
mondrakeLooks ready to go to me.
Comment #5
catchCommitted/pushed to 8.x, thanks!
Comment #7
fietserwin