Something changed in the last 48 hours -- I'm sure I went through the install UI either yesterday or the day before and it was fine.

Today I went through the D8 UI install (standard install profile, English, PostgreSQL) and when it got to the "configure site" stage, it looked like this:
screen shot of fields hanging over the edge on configure page

All of the fields are hanging over into the blue section of the page. Not very pretty.

If it matters, I'm running Firefox version 18.0 (Yes, I know it's old, need to update, etc.).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Issue tags: +Needs manual testing

Certain There Was An Issue To Remove #size From Form fields

longwave’s picture

longwave’s picture

And the later comments in that issue suggest it was known to be broken at commit time, but #2193271: Remove default #size attribute from core should fix this.

longwave’s picture

Closed #2197187: Install output error as duplicate

sun’s picture

Issue tags: -Needs manual testing

Yes, #2193271: Remove default #size attribute from core has a working solution for this (much deeper) CSS problem space.

anksy’s picture

Assigned: Unassigned » anksy
jhodgdon’s picture

Assigned: anksy » Unassigned
Status: Active » Postponed
Related issues: +#2193271: Remove default #size attribute from core

It sounds like maybe we should postpone this issue until #2193271: Remove default #size attribute from core is addressed and then revisit to make sure this issue is fixed.

webchick’s picture

Priority: Normal » Major
Status: Postponed » Active

That issue is taking forever, and in the meantime this is totally embarrassing.

LewisNyman’s picture

Assigned: Unassigned » LewisNyman
LewisNyman’s picture

Assigned: LewisNyman » Unassigned
Status: Active » Needs review
FileSize
324 bytes

This is such a weird problem. So the textfields have max-width: 100% but fieldsets have the equivalent of min-width: content-width. Details here

This fix needs testing in IE9+, which I am unable to on my local. Anyone with a Browserstack account can use simplytest.me to do this.

LewisNyman’s picture

FileSize
1.78 MB

It's ok, I got someone here to test it. It does break IE, so we need to wrap some of the CSS in something Firefox specific, which is recommend in the stackoverflow answer.

LewisNyman’s picture

LewisNyman’s picture

FileSize
1.7 MB

It works in IE9!

corbacho’s picture

Status: Needs review » Reviewed & tested by the community

I could replicate the bug in Firefox 28.0 , and I could verify that patch still applies and fixes the issue.
In IE9 and IE10 is working ok

It's a Gecko-engine issue, so I think it's good to address the issue with that small fix suggested.
And it's self-documented, the CSS rule has the -moz prefix

sun’s picture

Since this is a temporary fix, not sure whether the added CSS shouldn't have a comment (@todo + @see) that says to remove this when the other issue is resolved?

LewisNyman’s picture

@sun let's double check that this is a temporary fix. What if we modify the form to add a #size attribute. Does it still break?

LewisNyman’s picture

Yeah turns out you can still break it, we shouldn't allow forms to break pages like this.

sun’s picture

FileSize
122.28 KB

we shouldn't allow forms to break pages like this

Yes, that's the nature of the 'size' attribute. It's a beast. That's why need to do #2193271: Remove default #size attribute from core + discourage its usage.


FWIW, grabbed from #13: The password confirm label is misplaced:

webchick’s picture

Status: Reviewed & tested by the community » Needs work
corbacho’s picture

Status: Needs work » Reviewed & tested by the community

The password confirm label thing is unrelated to this.
It is misplaced because JavaScript does not execute in IE9, so the "password strength widget" is broken. See #2235425: domready bug breaks Drupal behaviors

But when JS works, everything looks fine in IE9 and IE10. Screenshot http://monosnap.com/image/Nv1IhusxW0iXJis6fTwLRWViO4s6nq

  • Commit e81a0a7 on 8.x by webchick:
    Issue #2195781 by LewisNyman | jhodgdon: Configure Site page on install...
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Ok, great. Let's get this in then so the next alpha doesn't have a black eye. We can handle whatever else needs to happen in follow-ups.

Committed and pushed to 8.x. Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.