Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Before enforcing all field types to declare a schema, FieldableDatabaseStorageController::mapToStorageRecord()
had to rely on the property definitions of the field type to check if it can/should store multiple properties in an entity base table. That's not really correct (e.g. properties might be computed) and the storage controller should rely more on storage-related info/methods than typed data properties.
Proposed resolution
Change the getPropertyDefinitions()
call to getFieldDefinition()->getColumns()
.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2189007-5.patch | 1.35 KB | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedThis should do it.
Comment #3
amateescu CreditAttribution: amateescu commented...
Comment #4
BerdirCan you write a short issue summary why the new approach is better?
Comment #5
amateescu CreditAttribution: amateescu commentedOf course! Rewritten the issue summary and attaching a new patch to make the code more obvious about terminologies.
Comment #6
BerdirThanks, that looks good, setting back to RTBC assuming that testbot agrees, but you only renamed variables I think.
Comment #7
catchCommitted/pushed to 8.x, thanks!