Problem/Motivation

Before enforcing all field types to declare a schema, FieldableDatabaseStorageController::mapToStorageRecord() had to rely on the property definitions of the field type to check if it can/should store multiple properties in an entity base table. That's not really correct (e.g. properties might be computed) and the storage controller should rely more on storage-related info/methods than typed data properties.

Proposed resolution

Change the getPropertyDefinitions() call to getFieldDefinition()->getColumns().

Remaining tasks

None.

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

Status: Active » Needs review
FileSize
1.07 KB

This should do it.

Status: Needs review » Needs work

The last submitted patch, 1: 2189007.patch, failed testing.

amateescu’s picture

Status: Needs work » Needs review
FileSize
1.09 KB
990 bytes

...

Berdir’s picture

Can you write a short issue summary why the new approach is better?

amateescu’s picture

Issue summary: View changes
FileSize
1.35 KB

Of course! Rewritten the issue summary and attaching a new patch to make the code more obvious about terminologies.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, that looks good, setting back to RTBC assuming that testbot agrees, but you only renamed variables I think.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.