Updated: Comment 0

Problem/Motivation

#2104727: Move controller class out of route folder in toolbar module changed the used controller, but it did not moved the custom_access callback.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 interdiff.txt939 bytesjessebeach
#3 toolbar-namespace-2187991-3.patch1.44 KBjessebeach
#3 toolbar-namespace-2187991-3-fail.patch1.46 KBjessebeach
#1 toolbar-2187991-1.patch538 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
toolbar-2187991-1.patch538 bytes

Fix it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: +Needs tests

Hm. How did tests not blow up as a result of this?

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
FileSize
toolbar-namespace-2187991-3-fail.patch1.46 KB
toolbar-namespace-2187991-3.patch1.44 KB
interdiff.txt939 bytes

We didn't have test coverage for this.

Test added -- fail and pass versions.

The last submitted patch, 3: toolbar-namespace-2187991-3-fail.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

This seems to be enough test coverage to catch a similar regression in the future.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -quickfix +Quick fix

Awesome, thanks!

Committed and pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.