Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
We added a Drupal\Core\Url
class in #2153891: Add a Url value object which will be used all over the codebase, but its name conflicts with Drupal\Component\Utility\Url
. Even though they're in different namespaces, this clash is really unfortunate and bound to create confusion.
Proposed resolution
Rename Drupal\Component\Utility\Url
to Drupal\Component\Utility\UrlHelper
Remaining tasks
None.
User interface changes
None.
API changes
This utility class is renamed.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2184653-rename_url_to_urlhelper-9.patch | 36.17 KB | amateescu |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedNot sure if we need to wait for the other issue, this is a simple patch that makes sense on its own.
Comment #3
amateescu CreditAttribution: amateescu commentedPhpstorm--
Comment #4
amateescu CreditAttribution: amateescu commentedRerolled since #2153891: Add a Url value object got in first.
Comment #5
amateescu CreditAttribution: amateescu commentedComment #6
dawehnerPerfect! (beside of silly 80 chars in documentation I do ignore)
Comment #7
alexpottSeems like we still have things to convert.
Let's fix this
Comment #8
amateescu CreditAttribution: amateescu commentedAll fixed :)
Comment #9
amateescu CreditAttribution: amateescu commentedYAR!
Comment #10
Dries CreditAttribution: Dries commentedIt looks like these classes could be merged, at least partially. Probably best done later. Committed this patch to 8.x. as it helps resolve confusion.