We need to rename properties according core standards in views/Plugin/views/filter/ManyToOne.php

Part of meta-issue #2052421: [META] Rename Views properties to core standards

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

Status: Active » Needs review
FileSize
1.94 KB
bohart’s picture

Status: Needs review » Needs work

We need to replace "var" with "public/protected".
Please take a look at meta issue.

InternetDevels’s picture

Status: Needs work » Needs review
FileSize
1.95 KB

Change visibility of a property to protected

bohart’s picture

Status: Needs review » Needs work

The pedant in me said that we need strong coding standards everywhere.

protected $valueFormType = 'select';
->
protected $valueFormType = 'select';

InternetDevels’s picture

Status: Needs work » Needs review
FileSize
1.95 KB
tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Looks good :-)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

This seems like it's internal-only code so probably don't need a change notice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.