Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We need to rename properties according core standards in views/Plugin/views/filter/ManyToOne.php
Part of meta-issue #2052421: [META] Rename Views properties to core standards
Comment | File | Size | Author |
---|---|---|---|
#5 | rename_property_value_form_type-2183423-5.patch | 1.95 KB | InternetDevels |
Comments
Comment #1
InternetDevels CreditAttribution: InternetDevels commentedComment #2
bohartWe need to replace "var" with "public/protected".
Please take a look at meta issue.
Comment #3
InternetDevels CreditAttribution: InternetDevels commentedChange visibility of a property to protected
Comment #4
bohartThe pedant in me said that we need strong coding standards everywhere.
protected $valueFormType = 'select';
->
protected $valueFormType = 'select';
Comment #5
InternetDevels CreditAttribution: InternetDevels commentedComment #6
tstoecklerLooks good :-)
Comment #7
webchickCommitted and pushed to 8.x. Thanks!
This seems like it's internal-only code so probably don't need a change notice.