Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
After page load, active 'toolbar-tray' link requires double click to collapse/close expanded menu links.
Proposed resolution
To be determined.
Remaining tasks
To be determined.
User interface changes
No interface changes.
Comment | File | Size | Author |
---|---|---|---|
#19 | core-js-toolbar-doubleclick-2181525-19.patch | 942 bytes | nod_ |
Comments
Comment #1
Dragan Eror CreditAttribution: Dragan Eror commentedComment #2
Dragan Eror CreditAttribution: Dragan Eror commentedComment #3
maggo CreditAttribution: maggo commentedHere we go, tab IDs and DOM Elements were mixed up in the click handler
Comment #4
maggo CreditAttribution: maggo commentedComment #5
nod_Yay! thanks!
We use one
var
per line, could you reroll your patch to keep it consitant with the rest of the JS? thanks :)Comment #6
nod_Comment #7
Dragan Eror CreditAttribution: Dragan Eror commentedVariables are now set in separate lines.
Comment #8
Dragan Eror CreditAttribution: Dragan Eror commentedRemoved white space.
Comment #9
nod_+ var clickedTab = document.getElementById(event.target.id);
+ var clickedTab = event.target;
same :)
Comment #12
maggo CreditAttribution: maggo commentedd'oh! you're right
Comment #15
Dragan Eror CreditAttribution: Dragan Eror commentedTested #12, it works nice.
Comment #16
webflo CreditAttribution: webflo commentedComment #17
nod_rtbc+1
Comment #18
clemens.tolboomPlease update the summary to reflect something in line with #2165017: toolbar needs click twice to close due to jQuery calling getPreventDefault() as I guess these issues are the same.
Comment #19
nod_This is a reroll because the indentation standard changed for JavaScript files. No need for commit credit because of this reroll.
Comment #20
webchickCommitted and pushed to 8.x. Thanks!