Removed deprecated event listeners [#2177689]

Updated: Comment #N

Problem/Motivation

#1890784: Refactor configuration import and sync functions introduced the event 'config.installer.validate' also both dispatcher and listener. In #2095489: Separate out module install config code from import code the event dispatcher has been removed (ConfigInstaller.php file was removed) and it did not return with #2166065: Replace config_install_default_config with ConfigInstaller service.

Proposed resolution

Remove the event lister 'config.installer.validate'.

Remaining tasks

~~Get confirmation that the event dispatchers are no longer required.~~
~~Make the patch.~~

User interface changes

none

API changes

none

Comment	File	Size	Author
#4	config-remove-event-listeners-2177689-4.patch	649 bytes	Sutharsan
#4
#1	config-remove-event-listeners-2177689-1.patch	3.54 KB	Sutharsan
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Sutharsan CreditAttribution: Sutharsan commented 26 January 2014 at 09:49

Status:

Active

» Needs review

File	Size
config-remove-event-listeners-2177689-1.patch	3.54 KB

No confirmation yet if the events are really deprecated, but let's see what this patch does.

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 27 January 2014 at 11:03

Status:

Needs review

» Needs work

#2172561: Config overrides may spill over to undesired places also removes the global override subscriber (and is RTBC). That is indeed left around and ConfigFactory now does all that directly. I'm not at all sure about the config import subscriber though :/ Settings needs work since the global removal is duplicate.

Comment #3

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 27 January 2014 at 11:31

+++ /dev/null
@@ -1,48 +0,0 @@
-class ConfigImportSubscriber implements EventSubscriberInterface {
...
-    $events['config.importer.validate'][] = array('onConfigImporterValidate', 40);
-    $events['config.installer.validate'][] = array('onConfigImporterValidate', 40);

This should be left in as the config.importer.validate event still fires. However the config.installer.validate does not occur anymore.

Comment #4

Sutharsan CreditAttribution: Sutharsan commented 27 January 2014 at 14:11

Issue summary:	View changes
Status:	Needs work	» Needs review

File	Size
config-remove-event-listeners-2177689-4.patch	649 bytes

1 file was hidden/shown/deleted

File	Size
config-remove-event-listeners-2177689-1.patch	3.54 KB

So the only event handler to remove is 'config.installer.validate'.
No interdiff as the remaining patch is minimal now.

Comment #5

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 27 January 2014 at 14:44

Status:	Needs review	» Reviewed & tested by the community
Issue tags:		+Configuration system

#2172561: Config overrides may spill over to undesired places will remove the global override listener (unused). Alex Pott confirmed about the updated patch is fine. So let's do this.