Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
For tests, general reuseabilty etc. we should not mark methods as final.
Proposed resolution
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#6 | drupal-final_function-2176397-6.patch | 663 bytes | InternetDevels |
Comments
Comment #1
dawehner.
Comment #2
carsato CreditAttribution: carsato commentedPatch rolled.
removed "final" from getContextReference
Comment #3
carsato CreditAttribution: carsato commentedComment #4
carsato CreditAttribution: carsato commentedSorry. I can't get to remove wrong patches.
The good one is https://drupal.org/files/issues/core-8.x-2176397-final-functions_0.patch , the one visible in #3
Comment #5
star-szrThanks @carsato! While we're changing that line we might as well fix the coding standards violation, the opening curly brace should be on the same line as the function declaration. See https://drupal.org/coding-standards.
To send the patch for review, change the issue status to 'Needs review'.
Comment #6
InternetDevels CreditAttribution: InternetDevels commentedThere are several coding standards issues in this file (mostly related to inline comments). Should we fix them in this issue or open separate one?
Comment #7
star-szrSeparate issue please and you can add this one as a related issue. Thanks @InternetDevels!
Comment #8
star-szrAnd RTBC :)
Comment #9
star-szrComment #10
webchickCommitted and pushed to 8.x. Thanks!