Extracted from #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead:

Problem

  1. The database configuration form in the installer still uses 'db_prefix' instead of 'prefix'.

  2. The 'db_prefix' value is passed forward and converted into global $databases as-is.

  3. Only a dirty hack/@todo for PIFR happens to catch the wrong 'db_prefix' key and move it into the correct 'prefix' key.

Solution

  1. Fix the form definition to use 'prefix'.
  2. Remove the obsolete hack/@todo for PIFR.
  3. Fix WebTestBase::installParameters() to actually pass the correct form input values for the database configuration form step.
CommentFileSizeAuthor
#4 drupal8.db-prefix.4.patch2.64 KBsun
#3 drupal8.db-prefix.3.patch3.21 KBsun
#2 drupal8.db-prefix.2.patch3.79 KBsun
drupal8.db-prefix.0.patch4.68 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, drupal8.db-prefix.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal8.db-prefix.2.patch3.79 KB

Those test failures are actually caused by the removed futzing with global $databases in TestBase::changeDatabasePrefix(), which is still required, because the installer does not get a real settings.php.

(Yet - that's one of the major points of #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead)

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal8.db-prefix.3.patch3.21 KB

Great! Now also removing the @todo that was just commented out previously.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue tags: +API clean-up
FileSize
drupal8.db-prefix.4.patch2.64 KB

Removed the additional change to the form description from this patch, since that is irrelevant here.

This patch looks ready to me. I need it for #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue summary: View changes

Clarified issue summary. Reviews, anyone? :)

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

4: drupal8.db-prefix.4.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Yup, makes sense.

Thanks for the explicit issue summary, things like that help a lot!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Wanted to do this, actually :-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Database configuration form in installer still uses 'db_prefix' instead of 'prefix' » Change notice: Database configuration form in installer still uses 'db_prefix' instead of 'prefix'
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed c84a43d and pushed to 8.x. Thanks!

We need a change notice since the database configuration form has changed.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Change notice: Database configuration form in installer still uses 'db_prefix' instead of 'prefix' » Database configuration form in installer still uses 'db_prefix' instead of 'prefix'
Status: Active » Fixed
Issue tags: -Needs change record

Change notice: https://drupal.org/node/2181883

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Priority: Critical » Normal

Thank you for the change notice and the patch @sun.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.