This sentence, with former/latter anaphoric reference is confusing:

// Look at the default display and display for the view mode, and fallback to
// the former if the latter does not exist is disabled.

Replace the references with the actual nouns so a reader is not forced to parse a sentence for an already confusing concept.

// Look at the default display and display for the view mode, and fallback to
// the default display if the display for the view mode does not exist
// or is disabled.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

valthebald’s picture

Status: Active » Needs work

Can this be shorter please? Repeating definitions make understanding hard.
Something like

Look at ..., fall back to ... when not found

jessebeach’s picture

Status: Needs work » Needs review
FileSize
721 bytes
684 bytes

"Look at [1] and [2], fall back to [1] when [2] is not found"

Is the original template. I changed it to this template, taking out the unnecessary preamble:

"Fall back to [1] when [2] is not found"

// Fall back to the default display if the display for the view mode does
// not exist or is disabled."

Status: Needs review » Needs work

The last submitted patch, 2: docs-update-2176085-2.patch, failed testing.

jessebeach’s picture

Status: Needs work » Needs review

2: docs-update-2176085-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: docs-update-2176085-2.patch, failed testing.

jessebeach’s picture

Status: Needs work » Needs review

2: docs-update-2176085-2.patch queued for re-testing.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks - definitely less confusing!

This cannot get committed until after the 22nd as we're in an "only major/critical commits" pre-alpha week.

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.