Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Background
- #2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead architecturally changes Drupal\system\Tests\InstallTest to act as a base class for all tests for the interactive installer.
Proposed solution
- The gist of the InstallerTest class should be moved into a new InstallerTestBase class provided by Simpletest, so as to make it a formal base class for all interactive installer tests + advance on it.
- The resulting minimal Drupal\system\Tests\InstallerTest class should be moved into the Drupal\system\Tests\Installer\ namespace.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | test.installer.3.patch | 3.72 KB | sun |
Comments
Comment #1
tstoecklerFor now this is postponed on the parent issue.
Comment #2
jibranBack to Active.
Comment #3
sunHere we go.
Comment #4
sunI need to change a bit of the moved code over in #2176621: Remove global $databases, so it would be great if we could get this patch here committed first. :)
Comment #5
alexpottGreat - let's get this done.
Comment #6
sun3: test.installer.3.patch queued for re-testing.
Comment #7
sunAny chance to move forward here?
There are three issues that need to touch the InstallerTest code, so it would be great if we could move the file first — otherwise, this patch here would have to be re-rolled from scratch...
#318975: Remove confirmation page after installation
#1351352: Distribution installation profiles are no longer able to override the early installer screens
#2196241: Remove string translation services from TestBase container
Comment #8
sun3: test.installer.3.patch queued for re-testing.
Comment #9
sunNo love? :-)
Comment #10
webchickThis looks fine to me, as it's basically just moving code around. On IRC, I asked for a few other examples of what other installer tests we might use this base class for, and sun cited a few examples, like installer + translation tests, as well as tests for install profiles like e.g. #1351352: Distribution installation profiles are no longer able to override the early installer screens Sounds good to me.
Committed and pushed to 8.x. Thanks!
Comment #11
sunSorry, I just noticed an oversight in this patch:
#2206417: Bogus tests without test methods are reported as successful tests
We'll fix it over there.