Pages of managing form modes show no local tabs. Each entity affected

CommentFileSizeAuthor
#2 2172717-pass.patch1.82 KBandypost
#2 2172717-fail.patch1.1 KBandypost
#1 form-2172717-1.patch736 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
form-2172717-1.patch736 bytes

The generic form display mode route was never being used, the specific one with NULL was always reported. And for entity types without custom form displays (anything but user), there were no results from entity_get_form_modes().

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: -Needs tests
FileSize
2172717-fail.patch1.1 KB
2172717-pass.patch1.82 KB

Tested manually with nodes and account forms

Status: Needs review » Needs work

The last submitted patch, 2: 2172717-pass.patch, failed testing.

The last submitted patch, 2: 2172717-pass.patch, failed testing.

The last submitted patch, 2: 2172717-fail.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

2: 2172717-pass.patch queued for re-testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Title: Local tasks for Form display are broken » Missing local tasks on the 'Manage form display' page
Status: Needs review » Reviewed & tested by the community

Awesome! That's some quick turnaround :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Glad to see test coverage, too, because iirc this is like the 2nd or 3rd time this has happened in recent months.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.