Problem/Motivation

The "Edit shortcuts link in horizontal state is placed next to actual shortcuts and looks like one of them.

How Edit shortcuts link looks like now

This is not the case in vertical state where it's on gray background and aligned to the right.

Proposed resolution

Float the link to the right in horizontal state and maybe even replace with an icon which could take less precious space.

Visual cleanup of edit shortcuts link mockup

Remaining tasks

Write patch, test, review.

User interface changes

Edit shortcuts link moved to the right when toolbar is in horizontal state. Possibly link text replaced with icon.

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

philipz’s picture

First patch without the cog icon.

philipz’s picture

Issue summary: View changes
Issue tags: +CSS
FileSize
30.49 KB
3.07 KB

Here's a patch with cog icon. It's also improved over first one.

Updating summary image - cog icon in vertical state looks better on white background.

philipz’s picture

Status: Active » Needs review
mr.baileys’s picture

It might make sense to mark this issue as a duplicate of #1164782: The icon to add something to shortcuts wasn't clearly discoverable. and continue the discussion there (despite the title and even though that issue has a slightly larger scope, it also repositions the edit shortcuts link).

philipz’s picture

Thanks for the issue link!
I'm adding it as related for now as it's quite dated and screenshots over there do not even show orientation toggle.

The solution I'm proposing here is most of all to save space but also not to complicate things too much. The cog icon could be easily changed to something else though it's used a lot in many places so people should understand what it does. I'm open to discussion and we can close this issue later if that will be decided :)

Bojhan’s picture

The only thing I would consider is showing text on hover/focus because the cog can be confused with the cog used for "Configuration".

philipz’s picture

@Bojhan I was thinking the icon could also be the edit/pen icon but that's the same icon on the toolbar so duplicated twice near each other wouldn't look good either.

It might also be some kind of new icon based on star/favourite from #1490402: Redesign tabs and the content header? Here how it looks like for reference:
Favourite/star icon

Are you saying you would support this once the hover/focus text is right? :)

Bojhan’s picture

Hah, an icon that is like half star/half cog?

I would support this, the original design actually had this. We made it a label because it wasn't discoverable. I think with the new toolbar design its more discoverable.

philipz’s picture

I was thinking more like half star/half pen ;)
But seriously when you hover over the star it has a small plus or minus on it depending on the operation to happen. So a star/pen on the shortcuts bar could also improve understanding that the star next to title is related to it.

Edit: Of course the star is also next to "Shortcuts" tab on the main Toolbar so maybe that would be too much stars. I'll stick to the cog icon for a moment.

I'll update my patch later today.

philipz’s picture

The only thing I would consider is showing text on hover/focus

I've been looking into this and I don't want to invent something new here.
Do we have something similar anywhere else I could apply in this case? Is there a Drupal standard for this?
The orientation toggle for example does not have such text on hover though the icon is quite self explanatory.

Bojhan’s picture

Yes, shortcuts has this if you hover/focus on it. And its in the new redesign tabs issue.

philipz’s picture

Yes, this is the only one I found. It's very specific and later it might need a little improvement to be more modular. I'll try to make this hover work at all first.

philipz’s picture

Here we go. This patch is heavily based on redesigned tabs hover text. The most significant difference is that I had to make the hover text positioned absolutely.
Currently this is not the case in redesigned tabs patch #264 but maybe should be too.

Attaching a screen shot to show the hovered text:
Edit shortcuts hover text

webchick’s picture

Issue tags: +Usability, +styleguide

Cool! But if we're going to re-use the contextual links gear icon, I'd expect it to work/look like contextual links do. In other words, more of a drop-down behaviour for "Edit shortcuts" and whatnot a la #1164782-10: The icon to add something to shortcuts wasn't clearly discoverable. than this sort of strange one-off grey background styling (I realize the "Add" link uses it too, but i think that's an artifact of the old design seeping through).

Tagging with a couple of things to get some other opinions.

I would say though that it might make sense to hold off on issues like this and the aforementioned one until the Seven Style Guide is closer to completion. It changes the add button to more of a "star" icon that should hopefully be easier to find.

philipz’s picture

I totally agree to wait until Style Guide is more complete.

The more I think about it the more I agree this should be made into contextual links just for sake of unification.
If you agree I'll close this issue as duplicate, re-roll #1164782: The icon to add something to shortcuts wasn't clearly discoverable. and then rename it to something like "Make edit shortcuts link to contextual menu".

One more thing - this issue is important because "Edit shortcuts" really takes a lot of space in horizontal orientation and probably sometimes it takes even more when translated :)

Bojhan’s picture

@Philipz Yes, lets do that.

LewisNyman’s picture

Created #2207383: Create a tooltip component.

It would be nice if we could align the edit shortcuts text, we can make that improvement now without running into the icon problem. I'm also looking for low hanging fruit for sprinters :P

philipz’s picture

Wim Leers’s picture

Issue tags: +Novice

Can't we split the contentious "gear icon" part into another issue and at least get Edit shortcuts link moved to the right when toolbar is in horizontal state done already?

(Tagging novice for a sprint tomorrow; only changing the alignment is a good novice task; we could then tackle the bigger ambitions in a follow-up.)

a_thakur’s picture

Status: Needs review » Needs work

Patch in comment #1 does not work on latest codebase of 8.x

Wim Leers’s picture

Issue tags: +Needs reroll
soipo’s picture

soipo’s picture

As per #19 I am changing the CSS to move the link to the right and in RTL to the left .

soipo’s picture

Status: Needs work » Needs review
FileSize
50.09 KB

Adding screenshot of applied patch, and changing the issue status.

LewisNyman’s picture

Issue tags: +frontend
jlyon’s picture

@drupalcon austin

jlyon’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
8.88 KB
25.08 KB

Reviewed and tested in Chrome, FF.

https://drupal.org/files/issues/Screenshot%20from%202014-06-06%2013%3A20%3A39_0.png

https://drupal.org/files/issues/Screenshot%20from%202014-06-06%2013%3A20%3A22_0.png

The last submitted patch, 13: clean-up-edit-shortcuts-link-2170947-13-2.patch, failed testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 14b3d70 and pushed to 8.x. Thanks!

  • Commit 14b3d70 on 8.x by alexpott:
    Issue #2170947 by philipz, soipo: Visual cleanup of Edit shortcuts link.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.