Problem/Motivation
The "Edit shortcuts link in horizontal state is placed next to actual shortcuts and looks like one of them.
This is not the case in vertical state where it's on gray background and aligned to the right.
Proposed resolution
Float the link to the right in horizontal state and maybe even replace with an icon which could take less precious space.
Remaining tasks
Write patch, test, review.
User interface changes
Edit shortcuts link moved to the right when toolbar is in horizontal state. Possibly link text replaced with icon.
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#27 | Screenshot from 2014-06-06 13:20:22.png | 25.08 KB | jlyon |
#27 | Screenshot from 2014-06-06 13:20:39.png | 8.88 KB | jlyon |
#24 | Screen-Shot-2014-05-31-at-16.14.45.jpg | 50.09 KB | soipo |
#23 | clean-up-edit-shortcuts-link-2170947-23.patch | 494 bytes | soipo |
#13 | clean-up-edit-shortcuts-link-2170947-13-2.patch | 4.87 KB | philipz |
Comments
Comment #1
philipz CreditAttribution: philipz commentedFirst patch without the cog icon.
Comment #2
philipz CreditAttribution: philipz commentedHere's a patch with cog icon. It's also improved over first one.
Updating summary image - cog icon in vertical state looks better on white background.
Comment #3
philipz CreditAttribution: philipz commentedComment #4
mr.baileysIt might make sense to mark this issue as a duplicate of #1164782: The icon to add something to shortcuts wasn't clearly discoverable. and continue the discussion there (despite the title and even though that issue has a slightly larger scope, it also repositions the edit shortcuts link).
Comment #5
philipz CreditAttribution: philipz commentedThanks for the issue link!
I'm adding it as related for now as it's quite dated and screenshots over there do not even show orientation toggle.
The solution I'm proposing here is most of all to save space but also not to complicate things too much. The cog icon could be easily changed to something else though it's used a lot in many places so people should understand what it does. I'm open to discussion and we can close this issue later if that will be decided :)
Comment #6
Bojhan CreditAttribution: Bojhan commentedThe only thing I would consider is showing text on hover/focus because the cog can be confused with the cog used for "Configuration".
Comment #7
philipz CreditAttribution: philipz commented@Bojhan I was thinking the icon could also be the edit/pen icon but that's the same icon on the toolbar so duplicated twice near each other wouldn't look good either.
It might also be some kind of new icon based on star/favourite from #1490402: Redesign tabs and the content header? Here how it looks like for reference:
Are you saying you would support this once the hover/focus text is right? :)
Comment #8
Bojhan CreditAttribution: Bojhan commentedHah, an icon that is like half star/half cog?
I would support this, the original design actually had this. We made it a label because it wasn't discoverable. I think with the new toolbar design its more discoverable.
Comment #9
philipz CreditAttribution: philipz commentedI was thinking more like half star/half pen ;)
But seriously when you hover over the star it has a small plus or minus on it depending on the operation to happen. So a star/pen on the shortcuts bar could also improve understanding that the star next to title is related to it.
Edit: Of course the star is also next to "Shortcuts" tab on the main Toolbar so maybe that would be too much stars. I'll stick to the cog icon for a moment.
I'll update my patch later today.
Comment #10
philipz CreditAttribution: philipz commentedI've been looking into this and I don't want to invent something new here.
Do we have something similar anywhere else I could apply in this case? Is there a Drupal standard for this?
The orientation toggle for example does not have such text on hover though the icon is quite self explanatory.
Comment #11
Bojhan CreditAttribution: Bojhan commentedYes, shortcuts has this if you hover/focus on it. And its in the new redesign tabs issue.
Comment #12
philipz CreditAttribution: philipz commentedYes, this is the only one I found. It's very specific and later it might need a little improvement to be more modular. I'll try to make this hover work at all first.
Comment #13
philipz CreditAttribution: philipz commentedHere we go. This patch is heavily based on redesigned tabs hover text. The most significant difference is that I had to make the hover text positioned absolutely.
Currently this is not the case in redesigned tabs patch #264 but maybe should be too.
Attaching a screen shot to show the hovered text:
Comment #14
webchickCool! But if we're going to re-use the contextual links gear icon, I'd expect it to work/look like contextual links do. In other words, more of a drop-down behaviour for "Edit shortcuts" and whatnot a la #1164782-10: The icon to add something to shortcuts wasn't clearly discoverable. than this sort of strange one-off grey background styling (I realize the "Add" link uses it too, but i think that's an artifact of the old design seeping through).
Tagging with a couple of things to get some other opinions.
I would say though that it might make sense to hold off on issues like this and the aforementioned one until the Seven Style Guide is closer to completion. It changes the add button to more of a "star" icon that should hopefully be easier to find.
Comment #15
philipz CreditAttribution: philipz commentedI totally agree to wait until Style Guide is more complete.
The more I think about it the more I agree this should be made into contextual links just for sake of unification.
If you agree I'll close this issue as duplicate, re-roll #1164782: The icon to add something to shortcuts wasn't clearly discoverable. and then rename it to something like "Make edit shortcuts link to contextual menu".
One more thing - this issue is important because "Edit shortcuts" really takes a lot of space in horizontal orientation and probably sometimes it takes even more when translated :)
Comment #16
Bojhan CreditAttribution: Bojhan commented@Philipz Yes, lets do that.
Comment #17
LewisNymanCreated #2207383: Create a tooltip component.
It would be nice if we could align the edit shortcuts text, we can make that improvement now without running into the icon problem. I'm also looking for low hanging fruit for sprinters :P
Comment #18
philipz CreditAttribution: philipz commented1: clean-up-edit-shortcuts-link-2170947-1.patch queued for re-testing.
Comment #19
Wim LeersCan't we split the contentious "gear icon" part into another issue and at least get
done already?(Tagging novice for a sprint tomorrow; only changing the alignment is a good novice task; we could then tackle the bigger ambitions in a follow-up.)
Comment #20
a_thakur CreditAttribution: a_thakur commentedPatch in comment #1 does not work on latest codebase of 8.x
Comment #21
Wim LeersComment #22
soipo CreditAttribution: soipo commented1: clean-up-edit-shortcuts-link-2170947-1.patch queued for re-testing.
Comment #23
soipo CreditAttribution: soipo commentedAs per #19 I am changing the CSS to move the link to the right and in RTL to the left .
Comment #24
soipo CreditAttribution: soipo commentedAdding screenshot of applied patch, and changing the issue status.
Comment #25
LewisNymanComment #26
jlyon CreditAttribution: jlyon commented@drupalcon austin
Comment #27
jlyon CreditAttribution: jlyon commentedReviewed and tested in Chrome, FF.
Comment #29
alexpottCommitted 14b3d70 and pushed to 8.x. Thanks!