Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I would like to suggest to change /templates
to /theme
.
That way we can do in our template.php
function subtheme_theme(&$existing, $type, $theme, $path) {
return _bootstrap_theme($existing, $type, $theme, $path);
}
And it will include our custom *.vars.php
as well.
Looks some what more consistent and in line with the base theme.
Comments
Comment #1
Michsk CreditAttribution: Michsk commentedComment #2
markhalliwellAgreed, this should have happened.
Thanks @Lasac!
Committed c5411e9 to 7.x-3.x:
Comment #3
mmrares CreditAttribution: mmrares commentedComment #5
Michsk CreditAttribution: Michsk commentedThanks for committing!
Comment #6
markhalliwellPlease see the change record associated with this issue. The code in the issue summary will no longer work, nor is necessary as sub-themes now inherit this base-theme's theme registry alters.
Comment #7
Michsk CreditAttribution: Michsk commentedSorry for changing this status and i don't want to be nitpicking,,, But; we can now create func.vars.php in the /theme folder, now here's the real but. We can not organize it like Bootstrap does.
For example i want to do some region preprocessing, and would like to do theme/system/region.vars.php, but't thats a no go. I haven't yet looked in to it deeper, just came across this issue at this moment.
Comment #8
markhalliwellYou sure?
I've been actively working a client project using the dev version (to make sure this kind of stuff works) and I have things structured just like the base-theme.
Have you seen:
https://drupal.org/node/2224003 and https://drupal.org/node/2229627
Comment #9
Michsk CreditAttribution: Michsk commentedYes, nice. Thanks. With the latest dev (73) it works. I was using the 72 dev.
Again, thanks. Great job.
Comment #11
ryan.armstrong CreditAttribution: ryan.armstrong commentedMoving this to the 8.x-3.x branch as it has been committed to that branch. Making sure the fix gets tested in the Drupal 8 release.
Comment #12
ryan.armstrong CreditAttribution: ryan.armstrong commentedComment #14
markhalliwellActually, this needs to be changed back. I now remember why this was originally
/templates
, that is how everything in 8.x is structured. We should ensure that this is the same when people upgrade.TBH, it really doesn't matter where you put your files. Bootstrap iterates over all files and directories looking for the
.func.php
and.vars.php
files; it does not check only a specific path.Comment #15
markhalliwellComment #16
markhalliwell