Clean up Edit's Plugin class names and file locations [#2169505]

Edit's plugin interface is still called EditPluginInterface. That's utterly unhelpful/vague. It's named like that because it was introduced back in the day when Edit still used Create.js, and we all decided that it wasn't a good idea to call it CreateJSWidgetPluginInterface, also because these plugins would be the missing link between Edit and Create.js: they'd contain the glue.

So, now that Edit is stable, it is high time to give it its final name.

Finally, it has become customary AFAICT to have the plugin interface, the plugin base class (if any) and the plugin manager all live in the lib\Drupal\<modulename>\Plugin directory. Edit already does the latter, but the former two things it does not yet do.

This should be done after #2144879: Brush up MetadataGeneratorInterface::generate(Field|Entity)(): use FieldItemListInterface + better naming lands.

Comment	File	Size	Author
#2	edit_plugin_cleanup-2169505-2.patch	6.56 KB	Wim Leers
#2
#1	edit_plugin_cleanup-2169505-1.patch	7.74 KB	Wim Leers
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 8 January 2014 at 15:59

Status:

Active

» Postponed

File	Size
edit_plugin_cleanup-2169505-1.patch	7.74 KB

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 14 January 2014 at 10:36

Status:

Postponed

» Needs review

File	Size
edit_plugin_cleanup-2169505-2.patch	6.56 KB

1 file was hidden/shown/deleted

File	Size
edit_plugin_cleanup-2169505-1.patch	7.74 KB

#2144879: Brush up MetadataGeneratorInterface::generate(Field|Entity)(): use FieldItemListInterface + better naming landed, now we can do this.

Comment #3

jessebeach CreditAttribution: jessebeach commented 15 January 2014 at 19:38

This patch contains the following Class renames.

+++ b/core/modules/edit/lib/Drupal/edit/Plugin/InPlaceEditorBase.php
@@ -2,19 +2,18 @@
- * Contains \Drupal\edit\EditorBase.
+ * Contains \Drupal\edit\Plugin\InPlaceEditorBase.

+++ b/core/modules/edit/lib/Drupal/edit/Plugin/InPlaceEditorInterface.php
@@ -2,10 +2,10 @@
- * Contains \Drupal\edit\EditPluginInterface.
+ * Contains \Drupal\edit\Plugin\InPlaceEditorInterface.

+++ b/core/modules/editor/lib/Drupal/editor/Plugin/EditorPluginInterface.php
@@ -2,7 +2,7 @@
- * Contains \Drupal\editor\Plugin\EditPluginInterface.
+ * Contains \Drupal\editor\Plugin\EditorPluginInterface.