Convert COMMENT_HIDDEN & COMMENT_CLOSED & COMMENT_OPEN to a constant on the comment field interface

This approach moves these variables to CommentInterface and replaces the occurrences of those variables.

Regards.

Inline with #2169447: DX: Supply CacheBackendInterface::CACHE_PERMANENT as Cache::PERMANENT why not CommentItem::OPEN? Provides the best dx?
CommentInterface is the comment entity where as these constants are to do with the field

New round including new CommentItemInterface. Not sure about if it is placed in the right place...

Interdiff is not included because this patch differs a lot from the previous one.

Regards.

Re-rolling here.

Although #2097123: Deprecate comment_num_new() in favour of method on CommentManager has been postponed, I believe we can continue with this patch.

Regards.

Re-rolling

Re-rolling

Re-rolling

Change record added https://drupal.org/node/2197921

move_comment_const-2169361-13.patch no longer applies.

error: patch failed: core/modules/comment/lib/Drupal/comment/Tests/CommentFieldsTest.php:58
error: core/modules/comment/lib/Drupal/comment/Tests/CommentFieldsTest.php: patch does not apply

Re-rolling

class CommentItem extends ConfigFieldItemBase {

Shouldn't this now be

class CommentItem extends CommentItemInterface {

And perhaps we should consider adding isOpen(), isHidden(), isClosed() methods?

So then we could do

if ($this->currentUser->hasPermission('post comments') && ($this->currentUser->hasPermission('administer comments') || $entity->{$field_name}->isOpen())) {>/code>
Instead of
<code>if ($this->currentUser->hasPermission('post comments') && ($this->currentUser->hasPermission('administer comments') || $entity->{$field_name}->status == CommentItemInterface::OPEN)) {>/code>

<code>
+++ b/core/modules/forum/forum.install
@@ -5,6 +5,7 @@
+use Drupal\comment\Plugin\Field\FieldType\CommentItemInterface;

@@ -83,7 +84,7 @@ function forum_install() {
-    Drupal::service('comment.manager')->addDefaultField('node', 'forum', 'comment_forum', COMMENT_OPEN);
+    Drupal::service('comment.manager')->addDefaultField('node', 'forum', 'comment_forum', CommentItemInterface::OPEN);

We can remove the use and the CommentItemInterface::OPEN as this is the default value.

Hello

I'm adding those methods to CommentItem and ComentItemInterface. However, most of times, the comment status comparison is done against the ConfigFieldItemList class, like in the example, and these methods are not available at ItemList level.

We could create new FieldItemList class for comments, called CommentFieldItemList and its interface CommentFieldItemListInterface where we could add those methods in order to be able to do $entity->{$field_name}->isOpen();

What do you think?

Yes, adding methods on field item classes is not something anyone else is doing and has the mentioned issues, adding a class and interface to repeat it on the level would be pretty unfortunate.

New patch fixing class declaration and removing unnecessary reference in forum.install.

Re-rolling after #2200821: Rename Fieldinterface and FieldInstanceInterface

Re-rolling previous patch no longer applies.

Re-rolling. Previous patch no longer applies...

We need a change record for this before we can commit - once one exists can set back to rtbc

There is already a change record for this issue COMMENT_HIDDEN & COMMENT_CLOSED & COMMENT_OPEN converted to constants on CommentItemInterface.

Setting back to RTBC.

27: move_comment_const-2169361-27.patch queued for re-testing.

Missed it - sorry.

Committed fd2613d and pushed to 8.x. Thanks!

@alexpott no problem. Thank you so much :)