> 21 menu items under a parent = screwy weights [#216904]

This bug report comes from quicksketch, but I also was able to confirm.

If you put more than 21 items in a list (-10 to 10 weight), then all remaining items get -10. It is therefore impossible to weight your menus the way you want them.

Reproducing this is not as hard as you might think, because after enabling a dozen or so modules, you'll easily end up with > 21 items under admin/settings. For example, I enabled all core modules as well as a few odd-ball ones like Image*, Devel*, etc. I then moved "Throttle" above "Site maintenance" under Administer >> Site configuration and saved the form. Instead of these menu items appearing at the bottom of the list where they belonged, they were instead glomped right into the middle.

quicksketch says the fix for this is to make the menu page more like the taxonomy page where the weights are assigned according to the order of the $_POST array. He is unfortunately not going to have time to do this himself, however, as he's in LA next week and then off to Europe. :(

This might be critical, I'm not sure.

Comment	File	Size	Author
#6	tabledrag_weights-216904-5.patch.txt	1.62 KB	Gábor Hojtsy
#4	tabledrag_weights-216904-4.patch	1.61 KB	pwolanin
#4
#3	tabledrag_weights-216904-3.patch	2.14 KB	pwolanin
#3
#1	tabledrag_weights.patch	978 bytes	theborg
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

theborg CreditAttribution: theborg commented 4 February 2008 at 13:54

Status:

Active

» Needs review

File	Size
tabledrag_weights.patch	978 bytes

When there are more than 21 menu items for a given parent, tabledrag.js stops assigning weights after reaching +10.

This patch gives the remaining items the highest number possible.

Comment #2

csevb10 CreditAttribution: csevb10 commented 5 February 2008 at 00:40

In my opinion, this doesn't solve the underlying problem. This still creates a batch of menu items that can't be re-ordered as desired. The number of possible weights really needs to increase to allow for this case, it would seem.