Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.for some reason only user 1 can save images using the windows XP publisher. The other users have permissions to the images and can enter them just fine manually, but for some reason it goes through the whole process to the point of uploading, then takes very little time to upload. Apparently not uploading the images. Users have permission to create images and edit their own images.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | image_pub-216086-5.patch | 4.84 KB | egfrith |
Comments
Comment #1
egfrith commentedI've just taken over maintaining this module. I don't use Windows (or XP publisher) very often, so it would be of great help if you could let me know whether this is still a problem in the latest development verison of this module.
Comment #2
toniw commentedAs far as I can see, behavior of the XP-pub part of this module has not changed in the 25sep dev version.
I however do not concur this bugreport. Every user with 'administer images' access can upload images perfectly and add them to an existing or newly created image gallery.
On the other hand it does not make sense to me to require 'administer images' access to simply upload images. I can upload a single image without that level of access perfectly and I would expect the image_pub module to hand me an easy way to upload multiple images at once. If I do not have 'administer images' access, which is in fact an access right from within the image_gallery module, then I should just not be able to add those images to a gallery.
Comment #3
egfrith commentedI've looked at the code now (though not yet tried it). It looks at though:
1. You need to have the "administer images" permission to create an album.
2. You need to have "create images" permission to add images to any album.
3. The "administer images" permission is not sufficient to add images to an album
4. The "create images" permission is not sufficient to create an album.
This would seem to be the correct behaviour to me, as it appears to be the same as the "manual" way of uploading images.
From what you're saying (toniw), it would appear that (3) does not hold with the current dev version. It would be great if you could confirm this is the case, and also test whether (1), (2) and (4) hold or not.
Comment #4
toniw commentedJust tested with a (fairly) clean D5.9 install with image_pub 5.x-1.x-dev of 25sep:
(1) correct
(2) not correct. You also need "administer images" to do that.
(3) correct, but you need to upload an image first (requiring "create images")
(4) correct
Point is however, the userinterface does not give you the option to upload images without adding them to an album. And since adding images to an album requires 'administer images', effectively you must have both 'create images' and 'administer images' to successfully upload an image (and subsequently add it to an album)
I think it's maybe better to let the userinterface skip the album part of the dialog when the user does not have "administer images" access. I want my users to have a method of uploading multiple images at once without requiring more access levels than required for uploading just one image manually...
Comment #5
egfrith commentedSorry for the delay in looking at this. I'm finally having a look at the XP part of this module now. The attached patch (against drupal 6) fixes things for me, and I'm committing it to the 6 tree.This patch changes the semantics of _image_pub_album_access() so that "create" means "create album" and "update" means "create image in album". It then applies these semantics in _image_pub_xp_album() and also modifies _image_pub_xp_album_form() so that the album creation part of the form is hidden if you don't have permission.
If you'd like this to be applied to the drupal 5 tree, please set the version back to 5.x.1.x-dev and the status to patch (to be ported)