Remove DRUPAL_BOOTSTRAP_DATABASE [#2159501]

Step 1 and most trivial step in getting rid of bootstrap "phases" that have no place in an object-oriented service architecture:

The DRUPAL_BOOTSTRAP_DATABASE / _drupal_bootstrap_database() bootstrap phase just includes a PHP file for procedural functions only.

The file inclusion is moved into DRUPAL_BOOTSTRAP_PAGE_CACHE, which should be acceptable, because:

1. database.inc is just a few lines of code

2. once all "phases" are gone, all procedural helpers will be loaded in DRUPAL_BOOTSTRAP_FULL only.

This issue + effort competes with #2016629: Refactor bootstrap to better utilize the kernel, because I'm not able to see the point of having a concept of stacked bootstrap phases in D8's architecture. Migrating/converting them into DrupalKernel methods would be a waste of previous core contributor time and confusing at best.

Comment	File	Size	Author
#1	drupal8.bootstrap-database-die.0.patch	3.68 KB	sun
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sun

German

Karlsruhe

CreditAttribution: sun commented 18 December 2013 at 22:09

File	Size
drupal8.bootstrap-database-die.0.patch	3.68 KB

Comment #2

sun

German

Karlsruhe

CreditAttribution: sun commented 18 December 2013 at 22:17

Assigned:	Unassigned	» sun
Issue summary:	View changes

Comment #3

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 18 December 2013 at 22:20

Truth be told database.inc should die, db_ignore_slave() is the only function that doesn't wrap existing OO code.
But thats a pipe dream so +1.
We should consider marking everything in database.inc except that as @deprecated so we have the option to rip it out later.

Comment #4

ParisLiakos CreditAttribution: ParisLiakos commented 18 December 2013 at 22:27

+1 on @deprecated on everything in there except db_ignore_slave()

Comment #5

sun

German

Karlsruhe

CreditAttribution: sun commented 18 December 2013 at 22:37

We should consider marking everything in database.inc except that as @deprecated so we have the option to rip it out later.

That's a good idea, but not really relevant here :) So let's create a separate issue for that. :)

Comment #6

andypost

he/him

Russian

CreditAttribution: andypost commented 18 December 2013 at 23:11

+++ b/core/includes/bootstrap.inc
@@ -2024,6 +2013,7 @@ function _drupal_bootstrap_page_cache() {
   require_once __DIR__ . '/cache.inc';
+  require_once __DIR__ . '/database.inc';

suppose this should be moved latter in code

Comment #7

sun

German

Karlsruhe

CreditAttribution: sun commented 19 December 2013 at 01:36

suppose this should be moved latter in code

As explained in the issue summary:

The file inclusion is moved into DRUPAL_BOOTSTRAP_PAGE_CACHE, which should be acceptable, because:

1. database.inc is just a few lines of code

2. once all "phases" are gone, all procedural helpers will be loaded in DRUPAL_BOOTSTRAP_FULL only.

Any other issues or can we move forward here? :)