Updated: Comment #N

Problem/Motivation

When providing local tasks via a derivative, I specified 3 tasks all with 0 weight, in a given order (1-2-3).
The tabs were then rendered 3-1-2.

Proposed resolution

Remaining tasks

Write test, find fix

User interface changes

N/A

API changes

Not anticipated

CommentFileSizeAuthor
#3 local_tasks-2159471.patch2.16 KBdawehner
#3 interdiff.txt1.38 KBdawehner
#1 local_tasks-2159471.patch800 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
local_tasks-2159471.patch800 bytes

I guess we should order that by the way how they were inserted, I fear that internal code in the local task manager breaks that array indexing.

What about doing this?

Status: Needs review » Needs work

The last submitted patch, 1: local_tasks-2159471.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
interdiff.txt1.38 KB
local_tasks-2159471.patch2.16 KB

This fixes the tests and work pretty fine. Set to major as local tasks from all "dynamic" local tasks would be fixed by this.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue summary: View changes

Fixed issue summary, which for some reason had all < > as HTML entities so it didnt' format as tags.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

We should use the localized title as part of the order, like menu links- let's check Drupal 7

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

On the other hand - we might want order to be fixed regardless of locale - so we could also use route name to break ties?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Or we can just fix the bug and continue on later.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Reviewed & tested by the community

ok, let's make the bug go away at least.

  • Commit ce8541b on 8.x by alexpott: 
    Issue #2159471 by dawehner: Ordering of local tasks is arbitrary for...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed ce8541b and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.