In several places Drupal.dialog is called with either a string or a jQuery object, it should be a DOM element, see #2158943: Add a native dialog element to deprecate the jQuery UI dialog why this is important.

And soon we will want to actually use the <dialog> tag instead of divs.

CommentFileSizeAuthor
core-js-dialog-DOM-element.patch2.86 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

Manually tested. Still works perfectly. Verified that zero incorrect remaining calls exist. Only JS is changed, so unless testbot trips over itself, this will come back green. Hence: RTBC.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

core-js-dialog-DOM-element.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

core-js-dialog-DOM-element.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.