Updated: Comment 0

Problem/Motivation

Remove the amount of changes needed for #2151829: Doctrine annotation parsing takes an unacceptable amount of time/memory on install

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 doctrine-2157045.patch49.52 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Update doctrine/common to 2.5-dev » Update doctrine/common to 2.4-dev
Status: Active » Needs review
FileSize
doctrine-2157045.patch49.52 KB

Change composer.json, composer update doctrine/common

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Update doctrine/common to 2.4-dev » Update doctrine/common to 2.5-dev

.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

This is fine, although dev-master is not a fixed point in the history it's not like we have nailed down all the other dependencies to a certain tag or hash -- that's a different issue and we really should so that anyone can nuke vendor; rerun composer and get back to the same point where HEAD is.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Ok great, thanks!

Committed and pushed to 8.x.

For reference, on whichever bot this was tested on, test run time was about 1.5h. Let's see if we can make this more betterer. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.