Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now, there can't be a simpler one than this. The documentation is on https://drupal.org/node/2154215 and with extract, the example will be the role migration once that lands. Postponed on #2154209: Process refactor: multiple handling
Comment | File | Size | Author |
---|---|---|---|
#7 | 2154563_7.patch | 2.6 KB | chx |
flatten.patch | 2.19 KB | chx | |
Comments
Comment #1
chx CreditAttribution: chx commentedComment #2
dawehnerCan we have some comment which explains how this works together?
Comment #3
dawehnerchx told me that we use this kind of code without docs in other places.
Comment #4
chx CreditAttribution: chx commentedFor example https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21FileTrans...
Comment #5
webchickNone of us in IRC could figure out what that line of code did either. :P~ And just because we have other horrifying examples in core is no reason to add more. ;)
Added some more docs, including a pointer to the handbook page, and...
Committed and pushed to 8.x. Thanks!
Comment #6
webchickHuh. Well something obviously went horribly wrong there. :P Reverted for now since I introduced a syntax error by missing half the file. :( We want it to basically look like https://gist.github.com/webchickenator/94e5605ce970a7b688c0 but I don't have time right now to dig into why that's not working when applied as a patch.
Comment #7
chx CreditAttribution: chx commentedManually edited patches need to be fixed by
rediff
from patchutils.Comment #8
chx CreditAttribution: chx commentedThis was almost committed so surely it's ready.
Comment #9
chx CreditAttribution: chx commentedAnd thanks much for fixing Migrate docs. I have stated today in the podcast (and even demonstrated there as well) one really loses touch with reality after a time -- I have been using recursive iterators for years now so I had no clue they were a problem -- indeed when I looked at the need to have a flatten plugin this line of code came naturally to me.
Another thing we could do
Is that better?
Comment #10
larowlanI understood the intent of 9 faster than the earlier approach, due to lack of familiarity with the RecursiveIteratorIterator class
Comment #11
webchickNo, I think the code is fine, it just needed some explanation, which is there now. :)
Committed and pushed to 8.x, this time without breaking HEAD. ;) Thanks!