Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Now that plugins are picked up in subdirs, we can do away with D6Variable and put it back in d6/Variable where it belongs. As plugins are picked up by the system by plugin id this is a trivial even BC patch so I am RTBC'ing my own. The only change here is the unit test which doesn't have the entity manager to rely on.
| Comment | File | Size | Author |
|---|---|---|---|
| move_variable.patch | 2.38 KB | chx | |
Comments
Comment #1
chx CreditAttribution: chx commentedApparently the bot doesn't pick RTBC patches?
Comment #2
chx CreditAttribution: chx commentedBack to where it belongs.
Comment #5
chx CreditAttribution: chx commentedmove_variable.patch queued for re-testing.
Comment #6
chx CreditAttribution: chx commentedOK, back to RTBC.
Comment #7
webchickIt still would be good to have at least a +1 on this patch from someone else on the migrate team. It seems harmless enough, but we've definitely introduced issues with innocent looking patches, and it's good to know that you're on the same page with others on the team regarding where these things are located.
Crossing my fingers anyway and committing and pushing to 8.x.
Comment #8
chx CreditAttribution: chx commentedThis is the list of sources before the frst core patch in the d6 directory. This is why I said "belongs": http://drupalcode.org/sandbox/chx/2105305.git/tree/625fae75c0b47fac36dd5... every other one is already there; it was moved out so we can have a core patch; the rest stayed in d6 because they are not in active use yet just unit tested and unit testing worked in a subdir.
Edit: and yes, as you can see Variable was there too.
Comment #9
mikeryanLooks good to me!