h2 on footer blocks must be hidden by default but must show when its enable

This was in D7, see #845834: Fix Bartiks Header because its totally borked and bartik_preprocess_block (D7)

This was changed to hardcoded CSS in #1968360: Remove per-region block markup, which is a technically a regression.

I found block title visible on other footer section but only hide on main footer section. If we remove this css then block title would start appear

Processing the patch for review.

We unfortunately can't just remove the CSS that hides the titles. This is because as part of the Bartik design and certain blocks assigned to regions on install we do not want to show their titles.

See screenshot....
 

 
Therefore we need to consider how we can turn the block title visibility off by default for the footer items as well as getting rid of the CSS that hides them.

@emma.maria Some block titles are disabled by default by the install profiles, for example Bartik breadcrumbs in the Standard profile ('label_display'):

core\profiles\standard\config\install\block.block.bartik_breadcrumbs.yml

id: bartik_breadcrumbs
theme: bartik
weight: 0
status: true
langcode: en
region: breadcrumb
plugin: system_breadcrumb_block
settings:
  id: system_breadcrumb_block
  label: Breadcrumbs
  provider: system
  label_display: '0'

So the block title can be disabled by default, but the title should at least look decent if a site builder enable its, don't you think?

@idebr Agreed, we should do both.

Yes I agree. There is an existing issue for the footer block titles somewhere. I also experimented with the block install files to make sure I was on the right track with my instructions :) so yes let's do it!

We worked on this issue in Thursday's Sprint Code in DrupalCon LatinAmerica.

• Changed the default value to '0' (disabled) for label_display attribute in bartik_footer block.
• Fixed the menu links styles when the title is disabled on footer_fifth region.
• Removed the dotted line on the bottom of these menu links in order to enhance presentation as can be seen by the attached screenshot:
  

This patch was created with peer programming by juankvillegas, jidrone, ibustos, davidlfg, geffio, fredysan and andres-mejia

I went ahead and applied the patch in #9 and using the minimal profile along with Bartik, created a new custom block and added it to footer five. I can confirm the title does show up.

I used the patch in #9 with a standard profile installation, and it works for me.

Also, I saw the new menu links styling and looks pretty good.

Here is the final result:

+++ b/core/themes/bartik/css/components/footer.css
@@ -36,16 +36,12 @@
+#site-footer__bottom .menu li a:hover {
+  color: rgba(255, 255, 255, 0.95);
+}

@@ -115,12 +111,20 @@
+  color: #fcfcfc;
+  color: rgba(255, 255, 255, 0.8);
+  font-size: 0.857em;
+  border-bottom: none;
...
+  color: #fcfcfc;
+  color: rgba(255, 255, 255, 0.8);
+  font-size: 0.857em;
+  border-bottom: none;

It's not clear why there are changes to a styling here, this is about H2?

AFAIK the H2 is not a link here.

The screenshot in #13 shows that the header text is not legible.

There are changes needed to the styling because only removing the css that hides the H2 title converts the links to blue (check patch in #2)... so, there must be added some styles to put those links almost white again.

The titles are not legible, but they are not legible on all the footer area, and this issue was affecting only the Footer Fifth region, that's why we decided to do not include a fix for it here... I think it must be a separate issue.

In HEAD, there is no way to get a block title in the footer that violates our accessibility rules.
This patch now allows site builders to cause accessibility problems. Therefore it is the responsibility of this issue to fix it.

See #6, #7, and #8.

Actually in any Footer region from First to Fourth, titles can be normally enabled/disabled.

I'll search for the titles legibility issue and try to fix it too.

I did a quick (but responsible) research and I didn't find any issue related with titles legibility.

Fixed style issues that prevent to easily read block titles in footer.

Here is the final result with all the changes applied:

I just removed a commented style in #19

... and here are the styles with titles disabled in Footer Bottom section:

Patch no longer applies after #2422363: Rewrite the menu CSS components inline with our CSS standards was committed:

error: patch failed: core/themes/bartik/css/components/footer.css:115
error: core/themes/bartik/css/components/footer.css: patch does not applyt

The latest patch has caused design regressions to the footer_first to footer_fourth regions (lost the border and the spacing). The original intention of this issue was to fix the hidden by CSS force H2 titles in the footer which only occurs in the footer_fifth region and not the column regions.

The patch needs to be amended to keep the original layout and style of all the footer regions and only affect the H2 titles. If the styling to fix the footer_fifth title improves footer_first to fourth, by using a useful reusable CSS selector for all regions I am all for that.

Otherwise leave the other regions alone as there is an existing issue for footer first to fourth regions titles (which have correct visibility behaviour but bad contrast) here #2304971: Change default block title colors in Footer first to fourth regions to improve contrast.

I am not able to reproduce this issue. I guess problem is title of blocks should not visible if blocks on footers not enable. Which i tried by enabling/disabling blocks on footer regions but not able to find this issue. Is this resolved .

Still issue exist. I have enable the title of fifth block, but not able to see in footer block. and visiblity of other first-to-forth column block title is also not so clear.

Working on reroll.

Rerolled patch.

updated footer region one to four title color to be #ffffff, to increase contrast and differ from link color

@chloe I think this patch should be on https://www.drupal.org/node/2304971.
Scope of this issue is, just show title of footer_bottom/footer_fifth when user checked 'display title' in block configuration.

Pass to bot...

Please combine the last two patches. We can't introduce a visual regression. Pretty sure we had this conversation already.

Combining last two patches :)

@tim, sorry was not aware of.

@manjit,

+++ b/core/themes/bartik/css/components/footer.css
@@ -3,6 +3,9 @@
+  color: #f2f2f2;

color should be the same as we have for `.content`.

As per above comment, block title should have same color as block content.

+++ b/core/profiles/standard/config/install/block.block.bartik_footer.yml
@@ -9,7 +9,7 @@ settings:
-  label_display: visible
+  label_display: 0

I think the test is failing because this should not be an integer

+++ b/core/profiles/standard/config/install/block.block.bartik_footer.yml
@@ -9,7 +9,7 @@ settings:
-  label_display: visible
+  label_display: '0'

In previous patches, the value was a string

Let's see now.

Looks good now :) I think we have to close it now.

https://www.drupal.org/node/2398451 broke this patch?

Straight reroll.

Thanks @joshtaylor! Did a manual test to confirm the title is now displayed correctly when the title is not hidden:

CSS is not frozen in beta. Committed 66af922 and pushed to 8.0.x. Thanks!