Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As documented in the handbook. It's doxygen'd, it's tested, it's necessary. Go!
Comment | File | Size | Author |
---|---|---|---|
#6 | 2147811_6.patch | 5.04 KB | chx |
#6 | interdiff.txt | 469 bytes | chx |
#4 | interdiff.txt | 2.23 KB | chx |
#4 | 2147811_4.patch | 5 KB | chx |
Comments
Comment #1
dawehnerSo nice, all the parameters are doxygen'd but what is the function actually doing?
It would be great to at least tell people which class is tested here.
Comment #2
chx CreditAttribution: chx commentedComment #3
jibranHere are some more points and suggestions.
Extra space.
Runs
Typehint missing.
Fully namespaced class is required for typehint.
I think mix is fine but what about int|string|whatever and then in desc explain all the cases. Just a suggestion.
Incomplete.
Tests
Desc missing.
@var doc block missing.
Comment #4
chx CreditAttribution: chx commentedComment #5
dawehnerPoint 1.2 would be still nice.
Comment #6
chx CreditAttribution: chx commentedComment #7
chx CreditAttribution: chx commentedOpsie.
Comment #8
dawehnerThank you
Comment #9
webchickOk, chx spent a great deal of time with me walking me through this so I could understand it. Well, sort of. :) Made some docs improvements along the way, along with a @see to https://drupal.org/node/2129651 where this is all explained in a lot more details.
Committed and pushed to 8.x. Thanks!