Updated: Comment #N

Problem/Motivation

While working on #576276: Abort validation when the token validation fails, I attempted to use #token => FALSE, but it resulted in Undefined index: form_token

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 form-token-2143349.5.patch2.87 KBlarowlan
#5 interdiff.txt821 byteslarowlan
#2 form-token-2143349.1.patch2.07 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Submitting a form as an anonymous user when $form['token'] = FALSE results in an error » Submitting a form as an anonymous user when $form['#token'] = FALSE results in a notice
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
form-token-2143349.1.patch2.07 KB

this passes locally, not seeing the same warnings as previous issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Unless you're running the simpletests as an anonymous user, it won't fail.

Status: Needs review » Needs work

The last submitted patch, 2: form-token-2143349.1.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs work » Needs review
FileSize
interdiff.txt821 bytes
form-token-2143349.5.patch2.87 KB

perhaps this then, also we mustn't have test coverage for that functionality either

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Thanks, that works perfectly, and seems as good a place as any to unset it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

The before/after code here is definitely cleaner. Rock! I was a bit concerned about the ability to set #token to FALSE, but this logic already exists in FormBuilder::prepareForm and is simply copied here as well.

Committed and pushed to 8.x. Thanks!

amateescu’s picture

amateescu CreditAttribution: amateescu commented

Edit: sorry, wrong issue :/

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.