Updated: Comment #0

Problem/Motivation

After implementing #1941672: Remove Drupal\views\Plugin\query\QueryInterface there is still @var \Drupal\views\Plugin\query\QueryInterface referenced in ViewExecutable.

Proposed resolution

Replace \Drupal\views\Plugin\query\QueryInterface with \Drupal\views\Plugin\views\query\QueryPluginBase

Remaining tasks

-

User interface changes

-

API changes

-

CommentFileSizeAuthor
#1 vardoc-views-queryinterface-2143111-1.patch523 bytesderhasi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

derhasi’s picture

derhasi CreditAttribution: derhasi commented
Status: Active » Needs review
FileSize
vardoc-views-queryinterface-2143111-1.patch523 bytes

And there is the small patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Component: views.module » documentation
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice find!

Committed and pushed to 8.x. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Is this actually right? We normally want to have @var reference an interface if possible, not a base class?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

\Drupal\views\Plugin\query\QueryInterface was removed in #1941672: Remove Drupal\views\Plugin\query\QueryInterface. In that issue it is pointed out that Views generally does not provide interfaces, and in practice you will always extend the base class, so I think it is safe to reference that base class here.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

OK. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.