Problem/Motivation

When editing a translated node, the tab "Translation" is displayed at the bottom of the page, it would be more consistent to display it on the right column with other tabs.

Proposed resolution

Edit NodeTranslationController to move Translation tab from Additional settings to Advanced on the right column.

Before

After

CommentFileSizeAuthor
#7 before.jpg84.32 KBFrancescoQ
#7 after.jpg79.76 KBFrancescoQ
#2 translation-tab-to-advanced-group-2143023-2.patch1021 bytesFrancescoQ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented
Assigned: Unassigned » FrancescoQ
FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented
FileSize
translation-tab-to-advanced-group-2143023-2.patch1021 bytes
FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented
Status: Active » Needs review
Issue tags: +D8MI, +language-content, +sprint
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Needs work

Why did you move the weight?!

FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented

Because it was already defined in ContentTranslationController with a value of 10, so it wasn't changed when added in NodeTranslationController with 

  $form['content_translation'] += array(
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +Usability

Ok then. Looks good to me. However please post a screenshot of before/after, so we can make it clear for committers.

FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented
FileSize
after.jpg79.76 KB
before.jpg84.32 KB

Here are after/before screenshots

FrancescoQ’s picture

FrancescoQ CreditAttribution: FrancescoQ commented
Issue summary: View changes
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Great, thanks for putting that to the summary too. There are definitely other things to clean up about this form, but this is one good move :)

The last submitted patch, 2: translation-tab-to-advanced-group-2143023-2.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

2: translation-tab-to-advanced-group-2143023-2.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice one! This definitely makes the form look much clearer.

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.