Test for ValidReferenceConstraintValidator

I will take care

1. +++ b/core/modules/system/lib/Drupal/system/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,73 @@
   +  public static function getInfo() {
   ...
   +  public function setUp() {
   +    parent::setUp();
   

   miss @inheritdoc

2. +++ b/core/modules/system/lib/Drupal/system/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,73 @@
   +    ->setSettings(array('target_type' => 'user'));
   

   indentation missing.

Else test looks good!

This patch was green but it was not running the tests in the patch any more :)

Re-roll attached

Typo ("refence" -> reference)

1. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +/**
   + * @file
   + * Contains \Drupal\system\Tests\Entity\EntityTypeConstraintValidatorTest.
   + */
   

   This refers to EntityTypeConstraintValidatorTest, but this is in fact ValidReferenceConstraintValidatorTest.

2. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +use Drupal\system\Tests\Entity\EntityUnitTestBase;
   +use Drupal\system\Tests\TypedData;
   +use Drupal\Core\Field\BaseFieldDefinition;
   

   EntityUnitTestBase resides in the same namespace so this use statement is unnecessary.
   Change the order of the other two so they are in alphabetical order.

3. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +  public static $modules = array('field', 'user');
   

   Missing {@inheritdoc}.

4. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +    $this->assertEqual($violations->count(), 0, 'Validation passed for correct value.');
   

   Tip: you can use $this->assertFalse() to check for values that are 0.

5. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +    // Delete the referenced entity.
   +    $entity->delete();
   +    $violations = $typed_data->validate();
   +    $this->assertEqual($violations->count(), 1, 'Validation failed for incorrect value.');
   

   I like this approach!

6. +++ b/core/modules/system/src/Tests/Entity/ValidReferenceConstraintValidatorTest.php
   @@ -0,0 +1,69 @@
   +    $this->assertEqual($violation->getMessage(), t('The referenced entity (%type: %id) does not exist.', array('%type' => 'user', '%id' => $entity->id())), 'The message for invalid value is correct.');
   

   Strictly speaking according to coding standards the array should be split on a new line because it exceeds 80 characters. I do not feel very strongly about this ;)

The assertEqual() -> assertFalse() pattern occurred multiple times in the test, sorry I didn't point this out in my previous review. For the rest this is looking very good.

Thanks! Looking great now.

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.

html.

that beta evaluation looks good.
and the interdiff in #26 should be fine and come back green.

Committed e6e359b and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.