Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Updated: Comment #N
Problem/Motivation
While refactoring getAdminRouteInfo() I noticed it was used in Drupal\comment\Controller\AdminController::bundleInfo(). When I went to manually test my changes, I got an access denied (as user 1!), only then noticing the _access: 'FALSE'
in the routing definition.
It turns out that this route only exists for Field UI to attach itself to, and is not used. It could be a nice place to list the comment bundles, but a UI was never designed.
Proposed resolution
Let's not maintain dead code.
Remaining tasks
N/A
User interface changes
N/A, unless your were altering the route info yourself :)
API changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#7 | comment-bundle-info-2141523-7.patch | 3.54 KB | effulgentsia |
comment-bundle-info.patch | 2.59 KB | tim.plunkett | |
Comments
Comment #1
larowlanAssuming green
Comment #4
larowlancomment-bundle-info.patch queued for re-testing.
Comment #7
effulgentsia CreditAttribution: effulgentsia commentedI got tripped up on this today as well. Here's an updated patch.
Comment #8
effulgentsia CreditAttribution: effulgentsia commentedTagging this as a beta target, because it's needed as a step to get rid of CommentBundleEnhancer and comment.module's unnecessary use of those request attributes, which is part of #2124749: [meta] Stop using $request->attributes->get(MAGIC_KEY) as a public API.
Comment #9
andypostThis route was originally supposed to provide information about usage of comment bundle.
But later someone decided that it useless so let's get rid of it.
To remove
CommentBundleEnhancer
I think better way to introduce a new config entity to be used as bundle for comments, but this could lead to some performance regressionsonly needed for Field UI
Comment #10
catchCommitted/pushed to 8.x, thanks!