Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #N
Problem/Motivation
There is no scrollbar or can't scroll views style option popup.
Steps to reproduce:
- Create a content view
- Click format type (HTML list, Grid, Table etc)
- Select HTML grid or table list (ref: Screenshot)
- the option popup doesn't have scroller to select elements. But can use TAB to navigate to them. Scrolling here scrolls the main page instead of popup
(ref: Screenshot)
Proposed resolution
Remaining tasks
1. Issue patch
2. Write test case, if possible to check for scroller vs content
User interface changes
N/A
API changes
N/A
Related Issues
N/A
1. Before Patch
2. After Patch
Comment | File | Size | Author |
---|---|---|---|
#21 | scroll-after-patch.PNG | 79.25 KB | Anishnirmal |
#21 | scroll-before-patch.PNG | 45.54 KB | Anishnirmal |
#20 | views_scrollbar.2137849-20.patch | 612 bytes | m4olivei |
#7 | views_scrollbar.2137849-7.patch | 1.45 KB | MartiMcFlight |
#6 | Bildschirmfoto 2014-01-25 um 15.53.11.png | 82.77 KB | MartiMcFlight |
Comments
Comment #1
vijaycs85Comment #2
dawehnerGiven that this potentially affect a lot of forms I consider this major.
Comment #3
jmuzz CreditAttribution: jmuzz commentedThis code should be getting run on all these dialogs, but it was conditional on the existance of a data-drupal-views-offset element . You can see that this element is on some of the dialogs but not others. Look for some empty space under the title of a dialog that slightly increases the height of the grey area the title is on. I'm not sure if the intent is for it to only appear on some dialogs, it seems inconsistant.
This patch removes the check, but it may be better to make sure all the dialogs have this element instead.
Comment #4
jibranTagging for JS maintainers
Comment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedFor me patch in #3 works for all settings in admin/views/view/VIEWNAME.
Comment #6
MartiMcFlight CreditAttribution: MartiMcFlight commentedI think this solution is not satisfying, because:
Comment #7
MartiMcFlight CreditAttribution: MartiMcFlight commentedThis patch fixes the scrolling of the body when the modal is open but i don’t know how to fix the width of the modal when it’s content is bigger.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedPatch #7 stops Chrome/Firefox from scrolling in admin/structure/views/view/VIEWNAME without the modal.
Comment #9
Charles BelovAlso affects Row style options dialog
Steps:
1. Create a website on simplytest.me using alpha14
2. Click manage
3. Click views
4. Click Add new view
5. View name test
6. Check Create a page
7. Click Save and edit
8. For show, click Content
9. Select Fields
10. Click Apply
Actual results: Page: Row style options dialog text gets cut off, but there is content.
Workaround: Tab to any off-screen fields. However, if there is any section of text between tabable fields that is taller than the dialog box makes available for text, this workaround would not be sufficient.
This issue would be exacerbated if text is zoomed in for low-vision users, so adding the accessibility tag.
Comment #10
mgiffordRepeated your just fine @Charles Belov, thanks.
Any suggestion on how to repeat the example given by @MartiMcFlight in #6?
Comment #11
mgiffordComment #12
dawehnerIt would be great if someone would have an idea how to fix it properly :)
Comment #13
pefferen CreditAttribution: pefferen at Triquanta commentedI cannot reproduce the error in 8.0-beta9. I followed the issuers steps and the steps in #9.
Comment #14
pefferen CreditAttribution: pefferen at Triquanta commentedComment #15
nod_Still happening in dev.
Comment #16
nod_We only want to have the change in
dialog.views.js
no change on the body so patch #3 is the way to go. Can someone reroll/reup the patch?#6.1: it's how it is, we considered doing something like that but decided against when implementing the original dialog API. We can discuss again if you feel there is a need but it's a new issue, nothing to do with this bug.
#6.2: feature request, should be a new issue.
Comment #17
m4oliveiI'm also still seeing this issue on HEAD. Applying the patch in #3 fixes the issue. While it would be nice to have, I don't think we have to fix the issue where the rest of the page scrolls when you get to the bottom of the dialog content. That's the current behaviour in D7 views. Maybe open a follow up for that, as I agree would be nice.
Also, that patch in #3 does apply cleany against HEAD, so no-need for re-roll.
Comment #18
m4oliveiComment #19
nod_if still applies, please reup. It's easier for core committers when the patch to apply is always the last one.
Comment #20
m4oliveiAhh, I see, sorry about that, new to core dev, didn't know what you meant. Here's a reup of #3 :).
Comment #21
Anishnirmal CreditAttribution: Anishnirmal commentedBefore and after Screenshots
Comment #22
nod_+1 RTBC
Comment #23
alexpottThis issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 28f3002 and pushed to 8.0.x. Thanks!