Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I wanted a javascript formatter for the widget, and figured others could use it as well. Will upload patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | javascript_formatter-2134491-4.patch | 1.93 KB | Paulmicha |
| #2 | javascript_formatter-2134491-2.patch | 2.09 KB | fsanfili |
Comments
Comment #1
fsanfili CreditAttribution: fsanfili commentedThis patch is only for the D7 branch.
Comment #2
fsanfili CreditAttribution: fsanfili commentedUse this patch instead -- retrieves the sdk.js from soundcloud via https.
Comment #3
fsanfili CreditAttribution: fsanfili commentedAs I make improvements to this, shall I bother to upload them? attila.fekete, are you likely to use this patch in the module, or am I going to have to patch my own copy with future releases anyway?
Comment #4
Paulmicha CreditAttribution: Paulmicha commentedPrevious patch gave me warnings
→ commented out corresponding lines
+ cleaned up id
+ single (static) sdk init
Attached Patch javascript_formatter-2134491-4.patch against 7.x-1.4.
Comment #5
geraldito CreditAttribution: geraldito as a volunteer commentedThanks for the last patch, #4 works fine for me!
Comment #7
akoepke CreditAttribution: akoepke commentedThanks for the patch, I did commit it but then also made several fixes to it afterwards.
The JS SDK that was being loaded was broken (was calling the SoundCloud embed API via http), I have updated it to point to a newer version.
The way you included the external JS library and the inline init command was wrong. We should be making use of the #attached element to load Javascript like this. This will be loaded into the head of the site properly.
Instead of building the markup for the player inside the PHP file, I have created a template file and then used the standard render array to generate the markup. This keeps the code clean and also means others can override this in their own theme if needed.
Comment #8
akoepke CreditAttribution: akoepke commentedThis now needs to be ported over to the current 2.0 version of the player.
Comment #9
akoepke CreditAttribution: akoepke commentedComment #10
akoepke CreditAttribution: akoepke commentedThis has been added to the D8/9 module and a new release has been made.