Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When trying to disabling one of the fields of comments form, the throbber appears but no further action happens.
Can be tested on admin/structure/comments/manage/node__comment/form-display
A javascript error occurs reporting the following php error:
Fatal error: Call to a member function getBundles() on a non-object in core/modules/comment/lib/Drupal/comment/CommentManager.php on line 195
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff.txt | 810 bytes | chx |
| #7 | comment-form-disable-2131997.less-icky.patch | 3.7 KB | chx |
| #6 | comment-form-disable-2131997.less-icky.patch | 3.7 KB | larowlan |
| #6 | interdiff.txt | 3.06 KB | larowlan |
| #3 | comment-form-disable-2131997.2.fail_.patch | 1.67 KB | larowlan |
Comments
Comment #1
wesleydv CreditAttribution: wesleydv commentedThis patch fixes the issue by not updating form['#title'] when the request is called via ajax.
Not sure if this is the correct way of fixing this :)
Comment #2
larowlanWe will need to add a test here, thanks for the fix though.
Comment #3
larowlanadds tests and a non path-based fix
Comment #5
chx CreditAttribution: chx commentedThere must be a better way to test whether we are in an AJAX request than messing with paths.
Comment #6
larowlannow with 90% less yuck
Comment #7
chx CreditAttribution: chx commentedThis is nice. I have fixed such a minor issue in the test that you can't say I have RTBC'd my own: replaced assertFalse(empty with assertTrue
Comment #8
webchickNice. I just hit this today in prepping for a demo, only to find an RTBC patch waiting. :D
Committed and pushed to 8.x. Thanks!