Variable to config: language.negotiation [d7]

working on this.

I think that we need to postponed this to D7. The variables in D8 are:

session:
  parameter: language
url:
  source: path_prefix
  prefixes:
    en: ''
  domains:
    en: ''

You can enable multiple system detection and order with a weight (See image attached). But In D6 we have only a variable (language_negotiation see https://api.drupal.org/api/drupal/includes%21locale.inc/function/locale_...). Then I think that we can't map :(.

What do you think?

I talked with chx in irc and we move to postponed.

I guess this is still blocked on #2108599: Convert language_default to CMI and #2102477: Convert remainder of language negotiation settings to configuration system.

Blocking issues now unblocked

I wasn't able to test this locally, I got a wierd recursion error. I think that's probably just my setup though.

Just applied the patch and run the test locally. Here's the output:

---- Drupal\migrate_drupal\Tests\d7\MigrateLanguageNegotiationTest ----


Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Pass      Other      MigrateTestBase.p   49 Drupal\migrate\Tests\MigrateTestBas
    Enabled modules: locale, migrate_drupal, migrate
Fail      Other      MigrateLanguageNe   49 Drupal\migrate_drupal\Tests\d7\Migr
    Value NULL is identical to value false.
Fail      Other      MigrateLanguageNe   50 Drupal\migrate_drupal\Tests\d7\Migr
    Value NULL is identical to value false.

The last patch was not good. Here's another try.

I have a strange problem.

In the test runner I get a failure at line 50.

Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Pass      Other      MigrateTestBase.p   49 Drupal\migrate\Tests\MigrateTestBas
    Enabled modules: locale, migrate_drupal, migrate
Pass      Other      MigrateLanguageNe   49 Drupal\migrate_drupal\Tests\d7\Migr
    Value 'language' is identical to value 'language'.
Fail      Other      MigrateLanguageNe   50 Drupal\migrate_drupal\Tests\d7\Migr
    Value 'path_prefix' is identical to value false.

It turns out that url.source is set to path_prefix.

This is the literal value of url.source in /core/modules/language/config/language.negotiation.yml

I don't understand why this value isn't being set to boolean FALSE as a result of the test.

I've removed the debugging line from the end.

There were a couple issues. One on the dump, where the second variable wasn't being created. The other one is the name of the language module (no longer locale) on the test. I've also fixed the test to use values more similar to the real environment.

Committed to 8.x. I fixed some indenting and moved the migration into the install folder on the way in.

Will need to be submitted again to Core since moving from sandbox.

Needs to be updated and merged into the parent issue.

Updated.

Moved to language module

Reroll. Since interdiff fails and the changes are minimal, I've included a diff

Except for these two things, looks great.

1. +++ b/core/modules/language/migration_templates/d7_language_negotiation_settings.yml
   @@ -0,0 +1,19 @@
   +dependencies:
   +  module:
   +    - language
   +    - migrate_drupal
   

   This needs to be removed; config dependencies are not allowed in migration templates.

2. +++ b/core/modules/language/src/Tests/Migrate/d7/MigrateLanguageNegotiationSettingsTest.php
   @@ -0,0 +1,42 @@
   +use Drupal\migrate_drupal\Tests\d7\MigrateDrupal7TestBase;
   +/**
   

   Nit: Need an extra line between the use statement and the doc comment.

Both fixed.

Noice. Pre-emptive RTBC assuming testbot passes.

Committed and pushed to 8.0.x. Thanks!

I'm not sure if this is enough, I think we need language_types config too. I will create another issue for that, now looking from d6 perspective but d7 should follow.

@penyaskito, language_types is at Variable to config: language.types [d7].

This is not migrating language prefixes. Created #2625148: [PP-1] Migrate language prefixes and domains to language.negotiation [d7] for that.