Steps to reproduce:
- Create a view with field rows, not entity
- Add atleast one field
- Enable 'Use aggregation' setting for the view under advanced fieldset
- click 'Aggregation settings' link for your field
- FATAL
The form is still trying to use field_info['columns'], assuming this is an array. This is a Field config entity now, but also doesn't have a columns property. So we can use the getColumns() method instead.
Here is the fix, don't have time to do test coverage right now, but will do later.
Comment | File | Size | Author |
---|---|---|---|
#1 | interdiff-2126973-1.txt | 2.52 KB | damiankloip |
#1 | 2126973-1.patch | 5.11 KB | damiankloip |
#1 | 2126973-1-tests-only.patch | 2.52 KB | damiankloip |
vdc.field-ui-aggregation.patch | 2.59 KB | damiankloip | |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedHere is a quick test for this in the UI.
Comment #3
damiankloip CreditAttribution: damiankloip commentedNot sure, but before that would have stayed as needs review ;)
Comment #4
dawehnerA fatal is a fatal, and should be considered critical.
+1 for the patch, just perfect.
Comment #5
catchCommitted/pushed to 8.x, thanks!