OMG this was not removed?? The usages are gone, this must be removed too. It was only added as a stopgap till module disable was gone.

CommentFileSizeAuthor
#4 interdiff.txt889 byteschx
#4 2124537_4.patch2.38 KBchx
dont_add_namespaces.patch1.51 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, dont_add_namespaces.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Nuke the Eldritch Abomination EntityManager::addNamespaces » Move EntityManager::addNamespaces() and EntityManager::doDiscovery() back into __construct()
Status: Needs work » Reviewed & tested by the community

I missed this being added in #1497374: Switch from Field-based storage to Entity-based storage. Please let's do this.

chx’s picture

chx CreditAttribution: chx commented
Title: Move EntityManager::addNamespaces() and EntityManager::doDiscovery() back into __construct() » Nuke the Eldritch Abomination EntityManager::addNamespaces
FileSize
2124537_4.patch2.38 KB
interdiff.txt889 bytes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2124537_4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

#4: 2124537_4.patch queued for re-testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed 97fc3d3 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.