No need to add the role="button" to button element.

#1719640: Use 'button' element instead of empty links
#1964880: Convert the Overlay close button from an anchor element to a button element.

CommentFileSizeAuthor
remove_role_button.patch719 bytesdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs accessibility review

Just adding a tag.

mimes’s picture

mimes CreditAttribution: mimes commented

I've tested the patch and checked it with WAVE (for structure/semantics) and Fangs, NVDA, ChromeVox, etc (screen-reading software). It doesn't seem to affect a site's accessibility that much; I agree that the role='button' is unnecessary.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs accessibility review

Agreed that it's redundant.

Thanks for doing the testing!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

remove_role_button.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +JavaScript

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.