EditorImageDialog assumes File module is enabled: add dependency on File module

Updated: Comment #0

Problem/Motivation

Not only does EditorImageDialog assume that the File module (and its managed_file element type), worse: the configuration form editor_image_upload_settings_form() assumes it too!

This means that when the File module is disabled, the image uploading functionality will break. Instead, it should just be disabled.

Proposed resolution

Two options:

1. Easiest, but least flexible: let editor.module depend on file.module
2. Complex but most flexible: let editor.module detect whether file.module is enabled in every bit of code that is related to file uploads, and only when it is enabled, show that functionality and settings. This has repercussions for every text editor module (like ckeditor.module) though: it will have to detect whether editor_image_upload_settings_form returned anything at all, and if not, react accordingly.

Remaining tasks

TBD.

User interface changes

None.

API changes

None.

Related Issues

• #2117661: Disable inline images when image module is uninstalled
• #1932652: Add image uploading to WYSIWYGs through editor.module