There is an unused variable in the file LocaleUpdateBase.php in a variable declaration

protected $tranlations_directory;

This needs to be removed.

CommentFileSizeAuthor
#5 drupal8.locale-module.2119045-5.patch922 bytesborisbaldinger
#1 drupal8.locale-module.2119045-1.patch886 bytesborisbaldinger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisbaldinger’s picture

borisbaldinger CreditAttribution: borisbaldinger commented
Status: Active » Needs review
FileSize
drupal8.locale-module.2119045-1.patch886 bytes

Fixed spelling issue, created the patch and added it to the issue.

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented
Status: Needs review » Reviewed & tested by the community

nice!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

This property is never used, it was added in #1742894: Get status of local and remote translation files for no apparent reason.

borisbaldinger’s picture

borisbaldinger CreditAttribution: borisbaldinger commented
Title: Spelling issue in LocaleUpdateBase class » Unused variable in LocaleUpdateBase class
Issue summary: View changes
borisbaldinger’s picture

borisbaldinger CreditAttribution: borisbaldinger commented
Status: Needs work » Needs review
FileSize
drupal8.locale-module.2119045-5.patch922 bytes

As tim has stated, we don't need this variable. I just removed it now and added the new patch.

Status: Needs review » Needs work

The last submitted patch, 5: drupal8.locale-module.2119045-5.patch, failed testing.

borisbaldinger’s picture

borisbaldinger CreditAttribution: borisbaldinger commented
Status: Needs work » Needs review

5: drupal8.locale-module.2119045-5.patch queued for re-testing.

Schnitzel’s picture

Schnitzel CreditAttribution: Schnitzel commented
Status: Needs review » Reviewed & tested by the community

nice! less unused code!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.