NumberDecimalFormatter settings form has not well defined '#weight' in its elements [#2114473]

Updated: Comment #N

Problem/Motivation

In Drupal\number\Plugin\field\formatter\NumberDecimalFormatter::settingsForm, form elements are not well defined and uses 'weight' instead of '#weight' as parameter, which leds to the following warning message:

Proposed resolution

Change 'weight' and use the right parameter '#weight'.

Remaining tasks

User interface changes

API changes

Comment	File	Size	Author
#11	weight_warning-2114473-11.patch	7.08 KB	plopesc
#11
#11	weight_warning-2114473-11-test-only.patch	5.95 KB	plopesc
#11
#7	weight_warning-2114473-7.patch	7.07 KB	plopesc
#7
#7	weight_warning-2114473-7-only-test.patch	5.94 KB	plopesc
#7
#4	weight_warning-2114473-3.patch	1.13 KB	plopesc
#4
#3	weight_warning-2114473-3.patch	1.13 KB	plopesc
#3
#1	weight_warning-2114473-1.patch	1.11 KB	plopesc
#1
	weight_warning.png	47.01 KB	plopesc

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 17 October 2013 at 18:32

Status:

Active

» Needs review

File	Size
weight_warning-2114473-1.patch	1.11 KB

Patch

Comment #2

amateescu CreditAttribution: amateescu commented 18 October 2013 at 09:15

Status:

Needs review

» Reviewed & tested by the community

Looks good :)

Comment #3

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 18 October 2013 at 12:19

File	Size
weight_warning-2114473-3.patch	1.13 KB

Rerolled after #2050835: Move Widget, Formatter, and FieldType plugin types to the Core\Field system is in.

Comment #4

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 18 October 2013 at 12:20

File	Size
weight_warning-2114473-3.patch	1.13 KB

~~Rerolled after #2050835: Move Widget, Formatter, and FieldType plugin types to the Core\Field system is in.~~ Same patch that #3

Comment #5

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 24 October 2013 at 07:58

#4: weight_warning-2114473-3.patch queued for re-testing.

Comment #6

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 7 November 2013 at 15:14

Issue summary:	View changes
Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

This means that this form is never ever tested

Comment #7

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 8 November 2013 at 17:52

File	Size
weight_warning-2114473-7-only-test.patch	5.94 KB

weight_warning-2114473-7.patch	7.07 KB

Adding tests

Comment #8

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 8 November 2013 at 17:53

Status:

Needs work

» Needs review

Comment #9

8 November 2013 at 19:20

Status:

Needs review

» Needs work

The last submitted patch, 7: weight_warning-2114473-7-only-test.patch, failed testing.

Comment #10

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 8 November 2013 at 22:46

Status:

Needs work

» Needs review

Back to needs review given that last patch worked.
Regards

Comment #11

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 5 December 2013 at 22:01

Issue tags:

-Needs tests

File	Size
weight_warning-2114473-11-test-only.patch	5.95 KB

weight_warning-2114473-11.patch	7.08 KB

Re-rolling after #1988612: Apply formatters and widgets to rendered entity base fields, starting with node.title

Comment #12

5 December 2013 at 23:35

The last submitted patch, 11: weight_warning-2114473-11-test-only.patch, failed testing.

Comment #13

swentel CreditAttribution: swentel commented 6 December 2013 at 15:48

Status:

Needs review

» Reviewed & tested by the community

Comment #14

swentel CreditAttribution: swentel commented 6 December 2013 at 15:49

+++ b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
@@ -189,21 +189,140 @@ function testNumberIntegerField() {
+    //Check number_integer formatter behavior.

Could a core committer add a space here ?

Comment #15

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 7 December 2013 at 01:47

Status:

Reviewed & tested by the community

» Fixed

Love the tests! Committed 5e91589 and pushed to 8.x. Thanks!

Fixed in commit as requested...

diff --git a/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
index 2ecd516..4dfe210 100644
--- a/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
+++ b/core/modules/number/lib/Drupal/number/Tests/NumberFieldTest.php
@@ -319,7 +319,7 @@ function testNumberFormatter() {
     $this->drupalPostAjaxForm(NULL, $edit, "${integer_field}_plugin_settings_update");
     $this->drupalPostForm(NULL, array(), t('Save'));

-    //Check number_integer formatter behavior.
+    // Check number_integer formatter behavior.
     $this->drupalGet('node/' . $node->id());

     $integer_formatted = number_format($random_integer, 0, '', $thousand_separator);