Problem/Motivation

There is a comment in node.module file that should be deleted because the mentioned issue is fixed:

function template_preprocess_node(&$variables) {
  $variables['view_mode'] = $variables['elements']['#view_mode'];
  // Provide a distinct $teaser boolean.
  $variables['teaser'] = $variables['view_mode'] == 'teaser';
  $variables['node'] = $variables['elements']['#node'];
  $node = $variables['node'];

  $variables['date'] = format_date($node->getCreatedTime());
  // @todo Change 'name' to 'author' and also convert to a render array pending                                                                                                         
  //   http://drupal.org/node/1941286.

Proposed resolution

Delete the following comment:

  // @todo Change 'name' to 'author' and also convert to a render array pending                                                                                                         
  //   http://drupal.org/node/1941286.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

N/A

CommentFileSizeAuthor
#1 2113221-1.patch552 bytessidharthap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sidharthap’s picture

Status: Active » Needs review
FileSize
552 bytes

Here is the patch file.

herom’s picture

Status: Needs review » Reviewed & tested by the community

confirming the issue, and the proposed patch fix.

Xano’s picture

Issue tags: -Documentation, -Novice

#1: 2113221-1.patch queued for re-testing.

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed 6829a65 and pushed to 8.x. Thanks!

tstoeckler’s picture

In fact the variable is still called $name, and per the todo should perhaps be renamed to $author?

herom’s picture

@tstoeckler yup. don't know how I missed that part :(

what should be done now?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.