I do not like to use this module as it requires jquery_update and jquery_update has proven to cause tons of other unknown issues in contrib and core. Issues you will never expect and may not able to fix.

Please remove this or fix the bugs in any other way.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

Looks like this 1.6 requirement has been removed, see https://github.com/harvesthq/chosen/pull/1555

hass’s picture

Aside of this if jquery_update is installed it has a default config of jquery 1.5 and not 1.7 or 1.8. You are not verifying this. This makes a dependency on jquery_update pretty useless.

adamdicarlo’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
628 bytes

Here's a simple patch to remove the dependency from chosen.info.

adamdicarlo’s picture

Have a look at https://github.com/opensourcery/chosen/tree/with-built-assets for a version of Chosen with the work from PR #1555 integrated, and with the compiled CSS and JS committed.

hswong3i’s picture

Status: Needs review » Reviewed & tested by the community

+1 for remove jquery_update dependency, as twbs_jquery may also perform the similar duty.

RTBC, and now applied to drustack_extra.make. Thank you very much ;-)

deanflory’s picture

Patch in #3 fails with current dev (2014-02-10) and 7.x-2.0-alpha4 (2013-Sep-19) so I have no idea what version this was coded against:

patch < chosen-remove_jquery_update-2113097-3.patch
patching file chosen.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file chosen.info.rej

Has it already been applied in another way or does the patch need to be rerolled?

Simple manual application was easy.

There's also jQuery Multi (jqmulti) that allows you to target specific libraries without altering core jquery (as with jquery_update):
https://drupal.org/project/jqmulti

maximpodorov’s picture

The patch is for the code from git, and it's applied correctly.

Alauddin’s picture

#3 patch removes the dependency line in chosen.info for jquery_update.

but does not use the jquerymulti when assigned in config setting.

So basically, removes the dependency, but now Chosen doenst work.

maximpodorov’s picture

Using chosen library from #4 is the best choice. It solves the problem completely.

Alauddin’s picture

#4 works...thanks for the Chosen lib branch that works with jquery 1.5.

So, install

1) Chosen
2) Install jquery_update > configure > default to 1.5 (just meeting the dependency requirement of Chosen module)
3) download the branch https://github.com/opensourcery/chosen/tree/with-built-assets and replace in /libraires/chosen

deanflory’s picture

The "with-built-assets" branch chosen library appears to work with or without jquery_update, which, I believe, was the whole point.

That library branch does have missing "X" delete/remove icons on multivalue fields, just have to copy them over from the original library download or create your own sprite that has the 5 icons (down arrow, up arrow, close normal, close hover, magnifying glass search).

Missing files' names are:

Eric_A’s picture

Priority: Normal » Major
FileSize
928 bytes

Here's a re-roll. It adds a hunk to fix the README.txt as well.

The 1.1.0 ZIP download contains the two mentioned sprite files.
And from the current README.md:

jQuery support: 1.4+

.

The dependency has been there in alpha3 and alpha4 if I'm not mistaken. Let's get rid of it before alpha5.

Dave Reid’s picture

Here is a combined patch against the 2.0-alpha4 release for makefiles.

Dave Reid’s picture

Version: 7.x-2.0-alpha4 » 7.x-2.x-dev
FileSize
1.96 KB

And a patch against the latest 7.x-2.x branch. The last patch was missing changes to the actual version downloaded.

Dave Reid’s picture

Status: Reviewed & tested by the community » Fixed
deanflory’s picture

Thank you Dave!

amool’s picture

Thank you for removing jquery_update dependency.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.