Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I do not like to use this module as it requires jquery_update and jquery_update has proven to cause tons of other unknown issues in contrib and core. Issues you will never expect and may not able to fix.
Please remove this or fix the bugs in any other way.
Comment | File | Size | Author |
---|---|---|---|
#14 | 2113097-chosen-no-jquery-update.patch | 1.96 KB | Dave Reid |
#13 | 2113097-chosen-no-jquery-update-alpha4-do-not-test.patch | 2.01 KB | Dave Reid |
#12 | chosen-remove_jquery_update-2113097-12.patch | 928 bytes | Eric_A |
#3 | chosen-remove_jquery_update-2113097-3.patch | 628 bytes | adamdicarlo |
Comments
Comment #1
hass CreditAttribution: hass commentedLooks like this 1.6 requirement has been removed, see https://github.com/harvesthq/chosen/pull/1555
Comment #2
hass CreditAttribution: hass commentedAside of this if jquery_update is installed it has a default config of jquery 1.5 and not 1.7 or 1.8. You are not verifying this. This makes a dependency on jquery_update pretty useless.
Comment #3
adamdicarlo CreditAttribution: adamdicarlo commentedHere's a simple patch to remove the dependency from chosen.info.
Comment #4
adamdicarlo CreditAttribution: adamdicarlo commentedHave a look at https://github.com/opensourcery/chosen/tree/with-built-assets for a version of Chosen with the work from PR #1555 integrated, and with the compiled CSS and JS committed.
Comment #5
hswong3i CreditAttribution: hswong3i commented+1 for remove jquery_update dependency, as twbs_jquery may also perform the similar duty.
RTBC, and now applied to drustack_extra.make. Thank you very much ;-)
Comment #6
deanflory CreditAttribution: deanflory commentedPatch in #3 fails with current dev (2014-02-10) and 7.x-2.0-alpha4 (2013-Sep-19) so I have no idea what version this was coded against:
Has it already been applied in another way or does the patch need to be rerolled?
Simple manual application was easy.
There's also jQuery Multi (jqmulti) that allows you to target specific libraries without altering core jquery (as with jquery_update):
https://drupal.org/project/jqmulti
Comment #7
maximpodorov CreditAttribution: maximpodorov commentedThe patch is for the code from git, and it's applied correctly.
Comment #8
Alauddin CreditAttribution: Alauddin commented#3 patch removes the dependency line in chosen.info for jquery_update.
but does not use the jquerymulti when assigned in config setting.
So basically, removes the dependency, but now Chosen doenst work.
Comment #9
maximpodorov CreditAttribution: maximpodorov commentedUsing chosen library from #4 is the best choice. It solves the problem completely.
Comment #10
Alauddin CreditAttribution: Alauddin commented#4 works...thanks for the Chosen lib branch that works with jquery 1.5.
So, install
1) Chosen
2) Install jquery_update > configure > default to 1.5 (just meeting the dependency requirement of Chosen module)
3) download the branch https://github.com/opensourcery/chosen/tree/with-built-assets and replace in /libraires/chosen
Comment #11
deanflory CreditAttribution: deanflory commentedThe "with-built-assets" branch chosen library appears to work with or without jquery_update, which, I believe, was the whole point.
That library branch does have missing "X" delete/remove icons on multivalue fields, just have to copy them over from the original library download or create your own sprite that has the 5 icons (down arrow, up arrow, close normal, close hover, magnifying glass search).
Missing files' names are:
Comment #12
Eric_A CreditAttribution: Eric_A commentedHere's a re-roll. It adds a hunk to fix the README.txt as well.
The 1.1.0 ZIP download contains the two mentioned sprite files.
And from the current README.md:
.
The dependency has been there in alpha3 and alpha4 if I'm not mistaken. Let's get rid of it before alpha5.
Comment #13
Dave ReidHere is a combined patch against the 2.0-alpha4 release for makefiles.
Comment #14
Dave ReidAnd a patch against the latest 7.x-2.x branch. The last patch was missing changes to the actual version downloaded.
Comment #15
Dave ReidCommitted #14 to 7.x-2.x: http://drupalcode.org/project/chosen.git/commit/eacd010
Comment #16
deanflory CreditAttribution: deanflory commentedThank you Dave!
Comment #17
amool CreditAttribution: amool commentedThank you for removing jquery_update dependency.