Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
As a follow up of #2027115: Allow views to override existing routing items we need to support keeping parameters in the path of routes
in order to be able to provide a view for the taxonomy/term/{taxonomy_term} route.
Proposed resolution
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#8 | vdc-2110845.patch | 18.73 KB | dawehner |
#8 | interdiff.txt | 4.5 KB | dawehner |
#4 | vdc-2110845-4.patch | 18.27 KB | dawehner |
#1 | vdc-2110845-1.patch | 26.07 KB | dawehner |
Comments
Comment #1
dawehnerThere we go. This adds quite a lot of additional test coverage but this was just needed in order to be sure that nothing breaks.
For sure we should maybe just get in the taxonomy/term/{} example in order to be sure that stuff works in a real world scenario.
Comment #2
tstoecklerThe patch contains #2098197: Add getAllRoutes() method to RouteProvider .
Comment #3
tstoecklerComment #4
dawehnerGood catch!
Comment #5
dawehner.
Comment #6
dawehnerGiven that enabling a view like taxonomy/{term} does not work at the moment I consider this as critical.
#2029509: Add a generic entity argument validation plugin.
Comment #7
damiankloip CreditAttribution: damiankloip commentedI know this works, it just seems a bit fragile. I can't see a better way though unfortunately. Maybe some comment about the numeric keys matching up would help?
Maybe these vars could be named better. Not sure of anything better right now though :p But the key is the parameter position? and the parameter is actually the param node (that would be in the slug) right?
I think this line needs to be finished off? :)
So if it gets to here, it's just a regular views arg, yes?
an argument handler.
assertInstanceOf
Extra newline.
assertInternalType?
Comment #8
dawehnerYeah it is kind of a hack, but I can't think of a better way, do you? We can iterate on that.
<3 position
Improved the documentation there.
I personally think the DX is worse with that, but I don't complain here.
Comment #9
dawehnerChanged title.
Comment #10
tim.plunkettBrilliant.
This looks great, let's get it in.
Comment #11
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #12
dawehnerAwesome, thank you very much!