Updated: Comment #0

Problem/Motivation

No spacing between field label and value when set to inline display.

Before:

Screenshot 2013-10-13 17.22.09.png

After:

Screenshot 2013-10-13 17.24.53.png

Proposed resolution

Fix it

Remaining tasks

Review the css

User interface changes

None

API changes

None

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense.

Wondering whether we should also look at the tags label and definitely the language label, because that one is really akward - but that might be fixable with #1471706: Allow hook_field_extra_fields() label to be displayed Above/Inline/Hidden, the same way fields and groups are

joelpittet’s picture

Status: Reviewed & tested by the community » Needs review

Damn, must have cross-posted somehwere else when I replied a few days ago. I was thinking this should be 1em instead of 5px, just to keep things relative as bases change.

swentel’s picture

FileSize
520 bytes

1em was a lot, so went for the straight conversion of px to em

joelpittet’s picture

If 1em length is too far, which is more than 5px... then 0.5em would fit the bill pretty close (6px @12px base from Bartik) Which is what most spaces are anyways.

En = 1/2em for those who are curious. *star rainbow*

http://en.wikipedia.org/wiki/En_%28typography%29

swentel’s picture

FileSize
518 bytes

Hmm yeah, still looks good then.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Great, thanks @swentel and @larowlan :)

alexpott’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed bc7a91a and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.