Cannot edit a date format after creating it. [#2110777]

Updated: Comment #0

Problem/Motivation

If you create a custom date-format and then try to edit it without changing the format, you receive an error 'This format already exists. Enter a unique format string.'

Proposed resolution

Fix it

Remaining tasks

Review

User interface changes

None

API changes

None

Test patch coming

Comment	File	Size	Author
#8	date-format-edit-2110777-8.patch	2.18 KB	herom
#8
#8	interdiff-2110777-6-8.txt	929 bytes	herom
#6	interdiff.txt	1.81 KB	larowlan
#6	date-format-edit-2110777.2.patch	2.21 KB	larowlan
#6
#5	interdiff.txt	915 bytes	herom
#5	date-time-fail-5.patch	1.33 KB	herom
#5
#5	date-time-pass-5.patch	2.18 KB	herom
#5
#2	date-time-pass.patch	2.18 KB	larowlan
#2
#1	date-time-fail.patch	1.33 KB	larowlan
#1
#1	date-time-pass.patch	1.33 KB	larowlan
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 13 October 2013 at 07:10

Status:

Active

» Needs review

File	Size
date-time-pass.patch	1.33 KB

date-time-fail.patch	1.33 KB

Something like this.
Simpletest playing up locally so hoping for red/green but could be wrong

Comment #2

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 13 October 2013 at 07:12

File	Size
date-time-pass.patch	2.18 KB

Wrong patch for .pass

Comment #3

13 October 2013 at 08:45

Status:

Needs review

» Needs work

The last submitted patch, date-time-pass.patch, failed testing.

Comment #4

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 13 October 2013 at 09:31

+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatFormBase.php
@@ -197,7 +197,7 @@ public function validate(array $form, array &$form_state) {
+      if ($format->getPattern() == $pattern && $format->id() != $this->entity->id()) {

will probably need a check for isNew() too

Comment #5

herom CreditAttribution: herom commented 13 October 2013 at 10:15

Status:

Needs work

» Needs review

File	Size
date-time-pass-5.patch	2.18 KB

date-time-fail-5.patch	1.33 KB

interdiff.txt	915 bytes

new patch.

Comment #6

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 13 October 2013 at 10:29

File	Size
date-format-edit-2110777.2.patch	2.21 KB

interdiff.txt	1.81 KB

Includes #4

Comment #7

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 15 October 2013 at 03:22

+++ b/core/modules/system/lib/Drupal/system/Tests/System/DateTimeTest.php
@@ -96,6 +96,13 @@ function testDateFormatConfiguration() {
+    $this->assertEqual($this->getUrl(), url('admin/config/regional/date-time', array('absolute' => TRUE)), 'Correct page redirection.');

This can be assertUrl(), right?

Otherwise this is great.