It looks around 55-60% width of the content area. It should be like 15% width as in other browsers.

CommentFileSizeAuthor
#2 poll-screenshot.png5.78 KBRowanw
#1 poll_column_width.patch459 bytesjrabeemer
poll-screenshot.jpg74.41 KBjrabeemer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrabeemer’s picture

jrabeemer CreditAttribution: jrabeemer commented
Assigned: Unassigned » jrabeemer
Status: Active » Needs review
FileSize
poll_column_width.patch459 bytes

Here's a fix that fixes the width of the 'Vote Count' column in polls module. IE7 wasn't respecting the size attribute of the input field and fields get cut off when widths are applied. This patch sets a consistent size.

Tested and works consistently in IE7, Safari 3.0.4 Windows, FF2, Opera 9.5

Rowanw’s picture

Rowanw CreditAttribution: Rowanw commented
Priority: Normal » Minor
FileSize
poll-screenshot.png5.78 KB

Your screenshot doesn't really demonstrate the problem clearly, I expected to see it exactly as IE7 rendered it. It took me a while to notice what you'd done.

I'm not sold on the patch though, the size of the 'choice' input field is 60, while the size of the 'count' input field is 5. IE is clearly misbehaving. I don't agree with adding more core CSS to cater for one of IE's trivial quirks.

jrabeemer’s picture

jrabeemer CreditAttribution: jrabeemer commented

I hear what you're saying. In a perfect world, we'd rip out all the IE css out of style.css and fix-ie.css from the Garland theme.

BrightLoudNoise’s picture

BrightLoudNoise CreditAttribution: BrightLoudNoise commented
Status: Needs review » Reviewed & tested by the community

Tested successfully in IE7 and IE6.

It handles the quirk at the module css level, which is far better than having to fix it in every theme in my opinion.

If down the road we implement an IE quirks CSS file for core, we could move it then.

jrabeemer’s picture

jrabeemer CreditAttribution: jrabeemer commented
Priority: Minor » Normal

IE6 and IE7 are our biggest audience.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Needs review

Who tested in other browsers? Firefox, Safari, Opera?

BrightLoudNoise’s picture

BrightLoudNoise CreditAttribution: BrightLoudNoise commented

Sorry about that Gabor, you are quite correct in pointing out the incompletness of my earlier test.

Tested successfully in Safari 3.0.4, Opera 9.25 and Firefox 2.0.0.11.

jrabeemer’s picture

jrabeemer CreditAttribution: jrabeemer commented
Status: Needs review » Reviewed & tested by the community

Thanks for the 2nd confirmation.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.