Node module is not marked "required", but is required by other required modules [#21084]

The "node" module isn't marked as one of the required modules, but it is used by a handful of other modules which are required. Specifically, the system and block modules both call the function node_list(), without using it through module_invoke.

Comment	File	Size	Author
#7	node.module.required.patch.txt	1.62 KB	robertDouglass
#2	node.module.required.txt	1.39 KB	robertDouglass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Thox CreditAttribution: Thox commented 20 June 2005 at 08:50

Duplicate

Comment #2

robertDouglass CreditAttribution: robertDouglass commented 9 September 2005 at 10:18

Version:	4.6.0	»
Status:	Closed (fixed)	» Needs review

File	Size
node.module.required.txt	1.39 KB

I couldn't find the duplicate so I'm reopening this. There are 206 instances of node_list alone in the repository (core+contributions). I cycled through 50 or so of these, and none of them check for the existence of the node module. Our collective usage of the node module indicates that it is, in fact, a required module.

Comment #3

jo1ene CreditAttribution: jo1ene commented 28 September 2005 at 00:59

Status:

Needs review

» Reviewed & tested by the community

It makes sense to me. I never really thought about it, but this is a good point. While I'm not aware of any problems with folks disabling the node module, I think it makes sense to cover our collective behinds. The code looks fine and works as expected. It just adds "node" to the required array.

Comment #4

Dries CreditAttribution: Dries commented 13 October 2005 at 10:09

Any idea of how hard it would be to fix the dependencies?

Comment #5

chx CreditAttribution: chx commented 13 October 2005 at 10:48

I know someone who has a nice dependency patch awaiting commit... adding a few depencies after that is trivial :P

Comment #6

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 27 February 2006 at 14:12

Status:

Reviewed & tested by the community

» Needs work

So, what to do with this one? I recall some opposition from Goba to making node.module required. I myself would be in favour.

The patch doesn't apply anymore.

Comment #7

robertDouglass CreditAttribution: robertDouglass commented 27 February 2006 at 14:23

File	Size
node.module.required.patch.txt	1.62 KB

How fitting that just 5 minutes ago I got burned by this. Please commit... I see no sense in not requiring the node module. Show me a site (are there any?) that doesn't use the node module, and I'll show you a site maintainer who will know how to revert this patch, and I think that we're talking at most about .0001% of all Drupal sites. Yet serious problems do and will continue to arise because unknowing admins can disable what is arguably the central piece of Drupal functionality.