Provide configuration schema for views.settings + update views.settings to reflect current configuration setup [#2107693]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

1. Create a configuration schema for views module general configuration(views.settings).
2. Add missing config keys and remove the keys that are not used.

Schema in place

Schema not yet in place
views.settings

Comment	File	Size	Author
#8	2107693-views-settings-8.patch	3.52 KB	rych
#8
#6	Screen Shot 2013-11-17 at 13.58.08.png	44.63 KB	vijaycs85
#5	2107693-views-settings-5.patch	3.03 KB	vijaycs85
#5
#2	2107689-system-config-schema-2.patch	9.85 KB	vijaycs85
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 8 October 2013 at 20:26

Title:	Provide configuration schema for system.action	» Provide configuration schema for views global configuration
Component:	system.module	» views.module

Comment #2

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 13 October 2013 at 18:15

Status:	Active	» Needs review
Issue tags:		+Needs manual testing

File	Size
2107689-system-config-schema-2.patch	9.85 KB

Initial patch...

Comment #2.0

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 13 October 2013 at 18:15

Issue summary:

View changes

Update for views.settings

Comment #3

a_thakur CreditAttribution: a_thakur commented 13 November 2013 at 05:08

@vijaycs85: The patch applied successfully, but I am unable to view schema for views.settings in the config inspector.

After applying the patch, views.schema.yml did not get changed, rather the files as in git status shown below got changed.

ashish@xeon:/var/www/d8$ git status
# On branch 2107693
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   core/modules/action/config/schema/action.schema.yml
#       modified:   core/modules/node/config/schema/node.schema.yml
#       modified:   core/modules/system/config/schema/system.data_types.schema.yml
#       modified:   core/modules/system/config/schema/system.schema.yml
#       modified:   core/modules/user/config/schema/user.schema.yml
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       .project
#       core/modules/comment/config/schema/
#       modules/config_inspector/
#       sites/default/files/
#       sites/default/settings.php
no changes added to commit (use "git add" and/or "git commit -a")

Comment #4

ianthomas_uk

he/him

English

Brighton, UK

CreditAttribution: ianthomas_uk commented 17 November 2013 at 13:05

Issue summary:	View changes
Status:	Needs review	» Needs work

@vijaycs85 I think you uploaded the wrong patch, presumably because this issue was initially mistitled.

Comment #5

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 17 November 2013 at 14:02

Title:	Provide configuration schema for views global configuration	» Provide configuration schema for views.settings + update views.settings to reflect current configuration setup
Issue summary:	View changes
Status:	Needs work	» Needs review

File	Size
2107693-views-settings-5.patch	3.03 KB

1 file was hidden/shown/deleted

File	Size
2107689-system-config-schema-2.patch	9.85 KB

Yes, seems it is wrong patch. Updating correct patch with changes in config itself (Removed always_live_preview_button and added exposed_filter_any_label).

Comment #6

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 17 November 2013 at 14:02

Issue tags:

-Needs manual testing

File	Size
Screen Shot 2013-11-17 at 13.58.08.png	44.63 KB

Manually tested in config_inspector

Comment #7

dawehner

German

CreditAttribution: dawehner commented 17 November 2013 at 17:19

+++ b/core/modules/views/config/schema/views.schema.yml
@@ -1,5 +1,76 @@
+              label: 'Allow embedded displays'
+        custom_theme:
+          type: string
+          label: 'Custom theme'
+        always_live_preview:

+++ b/core/modules/views/config/views.settings.yml
@@ -15,7 +15,7 @@ ui:
     display_embed: '0'
   custom_theme: _default

custom_theme is also not used anymore in the UI, we should drop it.

Comment #8

rych CreditAttribution: rych commented 17 November 2013 at 23:56

File	Size
2107693-views-settings-8.patch	3.52 KB

I've removed custom_theme both from views.chema.yml and from views.settings.yml.

As I know, in settings.yml file there should be true or false values for boolean fields, so I've changed '0' values to false, '1' to true.

Setting up boolean values seems to me a little confusing. In core/modules/system/config/sysrem.site.yml file the value is false for admin_compact_mode, but in https://drupal.org/node/1905070 there is enabled: '0' in the "An introductory example" section.

What's the correct form? Does it matters anyway?